[GitHub] trafficserver pull request: TS-4321: Keep response headers in Fetc...

2016-04-12 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/551#issuecomment-209208545 @maskit sound good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] trafficserver pull request: TS-4321: Keep response headers in Fetc...

2016-04-12 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/551#issuecomment-209208239 I'm going to push this fix without the test tomorrow, and I'll file a Jira for tests as a more general (but not too general) issue. Since tsqa has a test for chunk

[GitHub] trafficserver pull request: TS-4321: Keep response headers in Fetc...

2016-04-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/551#issuecomment-209163324 Fwiw, I'm running with this patch now on {ci,docs}.trafficserver.apache.org, and it's fixing the issues I've seen on e.g. https://ci.trafficserver.apache.org/ ---

[GitHub] trafficserver pull request: TS-4321: Keep response headers in Fetc...

2016-04-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/551#issuecomment-209159096 I don't think we should hold this back to enforce a tsqa test. However, I'd suggest you file a separate Jira to add such a test. Curious: Does any of the other H2 t

[GitHub] trafficserver pull request: WIP: Make Ptr pointer value private...

2016-04-12 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/565#issuecomment-209106620 Do you mean ``boost::intrusive_ptr``? That doesn't have any implicit conversions. If we keel OK about keeping the implicit conversion, then most of this di

[GitHub] trafficserver pull request: [TS-3857] Change ERROR default to not ...

2016-04-12 Thread sudheerv
GitHub user sudheerv opened a pull request: https://github.com/apache/trafficserver/pull/567 [TS-3857] Change ERROR default to not log into syslogs. @zwoop pls review You can merge this pull request into a Git repository by running: $ git pull https://github.com/sudheerv/traffi

[GitHub] trafficserver pull request: TS-4067: Memory leaks in parent select...

2016-04-12 Thread jrushford
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/566 TS-4067: Memory leaks in parent selection regression tests. Fixed most of the memory leaks in the ParentSelection regression tests. You can merge this pull request into a Git repository by

[GitHub] trafficserver pull request: WIP: Make Ptr pointer value private...

2016-04-12 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/565#issuecomment-209056115 I'm not sure we need to prevent the implicit conversion to a pointer. What's important is the inability to touch the member variable in `Ptr` that holds t

[GitHub] trafficserver pull request: TS-4341

2016-04-12 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/564#issuecomment-209001031 Well, it seems that this doesn't leak in the queue-- but I did find another bug (https://issues.apache.org/jira/browse/TS-4343) which we'll probably want to fix

Re: Deprecation of SSL v2/3

2016-04-12 Thread Yongming Zhao
+1 nice to move forward - Yongming Zhao 赵永明 > 在 2016年4月10日,下午8:42,Phil Sorber 写道: > > I'd like to propose that we deprecate SSLv2 and SSLv3 in ATS 6.2.0 and > remove it in 7.0.0. > > Currently our defaults do not enable them and have been that way for about > a year now. For 6.2.0 I'd like to

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59398467 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59397510 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59397488 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59397385 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59397333 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59397203 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59396994 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

Re: Deprecation of SSL v2/3

2016-04-12 Thread Dave Thompson
SSLv2 has been deprecated for 20 years.  No browsers supports it.   MACs are based on long dead MD5, and SHA1. Handshakes are not protected from MITM corruption, cipher downgrades, or padding attacks.  The ciphers are weak, some now considered merely obfuscation.   And now with DROWN, whole comp

[GitHub] trafficserver pull request: WIP: Make Ptr pointer value private...

2016-04-12 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/565 WIP: Make Ptr pointer value private. Make the actual pointer value of Ptr private so that code reaching in to do unsafe direct manipulate has to do it explicitly. Also remove the implic

Re: Deprecation of SSL v2/3

2016-04-12 Thread Sudheer Vinukonda
+1 On Tuesday, April 12, 2016 7:56 AM, Steven R. Feltner wrote: +1 > -Original Message- > From: Phil Sorber [mailto:sor...@apache.org] > Sent: Sunday, April 10, 2016 8:43 AM > To: dev@trafficserver.apache.org; us...@trafficserver.apache.org > Subject: Deprecation of SSL v2/3 >

RE: Deprecation of SSL v2/3

2016-04-12 Thread Steven R. Feltner
+1 > -Original Message- > From: Phil Sorber [mailto:sor...@apache.org] > Sent: Sunday, April 10, 2016 8:43 AM > To: dev@trafficserver.apache.org; us...@trafficserver.apache.org > Subject: Deprecation of SSL v2/3 > > I'd like to propose that we deprecate SSLv2 and SSLv3 in ATS 6.2.0 and >

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59389367 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

Re: Updates to clang-format for v6.2 LTS / 7.0.

2016-04-12 Thread Leif Hedstrom
> On Apr 11, 2016, at 9:48 PM, James Peach wrote: > >> >> On Apr 11, 2016, at 12:47 PM, James Peach wrote: >> >>> >>> On Apr 11, 2016, at 11:01 AM, Leif Hedstrom wrote: >>> >>> Hi, >>> >>> James and I’ve been looking at some changes to clang-format, wanted to take >>> it here first. Just

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59388857 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

Re: [GITHUB] MATT setup for committers

2016-04-12 Thread Leif Hedstrom
> On Apr 10, 2016, at 5:25 PM, Leif Hedstrom wrote: > > >> On Apr 7, 2016, at 11:17 AM, Leif Hedstrom wrote: >> >> In preparation for the migration to git-dual, if you are a committer, please >> visit >> >> http://id.apache.org >> >> >> and add your Github user ID to the appropriate

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59388313 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59386613 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59386515 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59386188 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59386294 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59384677 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59385843 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-12 Thread dragon512
Github user dragon512 commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-208934704 Sure, I think the point of the namespace it to define a concept or domain. This makes it easy to deal with class with the same name in different namespaces. For

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59385661 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59385596 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59385389 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59384993 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-12 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-208931667 They can be a good thing. It's not namespaces so much as the difficulty of code browsing the names within them. If you end up with very generic names in different

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59384742 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License,

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-12 Thread dragon512
Github user dragon512 commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-208902197 Why do you want to avoid namespaces? They are a good thing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] trafficserver pull request: TS-4341

2016-04-12 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/564#issuecomment-208754987 :eyes: I'm on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this