[GitHub] trafficserver pull request: TS-4341

2016-04-11 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/564#issuecomment-208718335 This isn't complete yet, still need to add handling for timeouts etc., but I wanted to get the PR opened to get some eyes on it :) --- If your project is set u

[GitHub] trafficserver pull request: Ts 4341

2016-04-11 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/564 Ts 4341 https://jira01.corp.linkedin.com:8443/browse/TRAFFIC-5688 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jacksontj/trafficserve

Re: Updates to clang-format for v6.2 LTS / 7.0.

2016-04-11 Thread James Peach
> On Apr 11, 2016, at 12:47 PM, James Peach wrote: > >> >> On Apr 11, 2016, at 11:01 AM, Leif Hedstrom wrote: >> >> Hi, >> >> James and I’ve been looking at some changes to clang-format, wanted to take >> it here first. Just running the new version of clang-format produces a patch >> of ab

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-04-11 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/541#issuecomment-208686127 I definitely think that ``ParseRules.cc`` is the right place for this. I suggest we reclaim one of the obsolete bits for this? --- If your project is set up for i

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-11 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-208685936 In general, I'd like to avoid namespaces, but I like the ``iobuf_allocator`` nomenclature; just need to make it consistent with existing iocore style using IOCamel

Re: Deprecation of SSL v2/3

2016-04-11 Thread xuchao
+1 to disable for client <-> proxy but please keep sslv2/v3 for proxy <-> origin. I'm implement a man in the middle ssl forward proxy with ats. 发自我的 iPhone 在 2016年4月11日,08:57,Uri Shachar 写道: >> On Apr 10, 2016, at 7:42 AM, Phil Sorber wrote: >> >> I'd like to propose that we deprecate SSLv2

[GitHub] trafficserver pull request: TS-4250 fix

2016-04-11 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/563#issuecomment-208658874 +1 on the fixes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request: TS-4250 fix

2016-04-11 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/563 TS-4250 fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/danobi/trafficserver TS-4250 Alternatively you can review and apply these cha

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-11 Thread mlibbey
Github user mlibbey commented on the pull request: https://github.com/apache/trafficserver/pull/560#issuecomment-208623709 Could you include a readme or better a doc page (https://docs.trafficserver.apache.org/en/latest/developer-guide/documentation/plugins.en.html) explaining what th

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-11 Thread mlibbey
Github user mlibbey commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59300496 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-11 Thread mlibbey
Github user mlibbey commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/560#discussion_r59300512 --- Diff: plugins/experimental/acme/acme.c --- @@ -0,0 +1,347 @@ +/** @file + +@section license + +Licensed under the Apache License

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-11 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/560#issuecomment-208591504 Looks ok, +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] trafficserver pull request: Fix broken test of min_keep_alive_conn...

2016-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4340 Add tests for per-origin conne...

2016-04-11 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/562 TS-4340 Add tests for per-origin connection limits You can merge this pull request into a Git repository by running: $ git pull https://github.com/jacksontj/trafficserver TS-4340 Alt

[GitHub] trafficserver pull request: Fix broken test of min_keep_alive_conn...

2016-04-11 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/561#issuecomment-208575789 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] trafficserver pull request: Fix broken test of min_keep_alive_conn...

2016-04-11 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/561 Fix broken test of min_keep_alive_connection This test was previously not setting the UUID per transaction (but rather per request). This was working because the configuration options set f

[GitHub] trafficserver pull request: TS-4339: Remove .pr file

2016-04-11 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: Updates to clang-format for v6.2 LTS / 7.0.

2016-04-11 Thread James Peach
> On Apr 11, 2016, at 11:01 AM, Leif Hedstrom wrote: > > Hi, > > James and I’ve been looking at some changes to clang-format, wanted to take > it here first. Just running the new version of clang-format produces a patch > of about 6,500 lines. This is mostly removal of superfluous empty lines

[GitHub] trafficserver pull request: TS-4339: Remove .pr file

2016-04-11 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/559#issuecomment-208521344 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] trafficserver pull request: TS-4320: Add ACME Plugin

2016-04-11 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/560 TS-4320: Add ACME Plugin This is a first pass at making an ACME plugin for ATS. This current version amounts to a simple static file server that leverages a CLI client, but there are plans

[GitHub] trafficserver pull request: TS-4339: Remove .pr file

2016-04-11 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/559 TS-4339: Remove .pr file Remove .pr hack now that we have MATT. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-04-11 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/541#issuecomment-208488556 @jpeach I looked into the idea of using ParseRules.cc and CompileParseRules with @shenzhang920 but it does't look like there are any free bits at the moment, shoul

Re: Updates to clang-format for v6.2 LTS / 7.0.

2016-04-11 Thread Phil Sorber
+1, +1, -1. #3 could be a +1 in the future. On Mon, Apr 11, 2016, 12:01 Leif Hedstrom wrote: > Hi, > > James and I’ve been looking at some changes to clang-format, wanted to > take it here first. Just running the new version of clang-format produces a > patch of about 6,500 lines. This is mostly

Updates to clang-format for v6.2 LTS / 7.0.

2016-04-11 Thread Leif Hedstrom
Hi, James and I’ve been looking at some changes to clang-format, wanted to take it here first. Just running the new version of clang-format produces a patch of about 6,500 lines. This is mostly removal of superfluous empty lines, and removing a space between a type cast and the variable. These

[GitHub] trafficserver pull request: TS-3995: Fix Akamai Live streaming

2016-04-11 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/330#issuecomment-208439499 Closing this per discussion above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] trafficserver pull request: TS-3995: Fix Akamai Live streaming

2016-04-11 Thread PSUdaemon
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4250 clang-format breaks on Centos ...

2016-04-11 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4250 clang-format breaks on Centos ...

2016-04-11 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/558#issuecomment-208431653 Seems reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request: TS-4250 clang-format breaks on Centos ...

2016-04-11 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/558 TS-4250 clang-format breaks on Centos 6 Change clang-format.sh to use native sha1sum command when available. You can merge this pull request into a Git repository by running: $ git pu

Re: Deprecation of SSL v2/3

2016-04-11 Thread Dave Thompson
+1 The consequences from DROWN (CVE-2016-0800 and CVE-2016-0703 ) are too severe on the whole shared cert infrastructure from just one machine being accidentally configured to allow SSLv2. I filed this ticket:https://issues.apache.org/jira/browse/TS-4247 On Sunday, April 10, 2016 8:33

[GitHub] trafficserver pull request: TS-4321: Keep response headers in Fetc...

2016-04-11 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/551#issuecomment-208206647 @jpeach I added a parameter to ``http2_generate_h2_header_from_1_1()`` to pass a ``HTTPHdr`` declared in ``send_headers_frame()`` instead of creating it with ``new