[GitHub] trafficserver pull request: TS-4328

2016-04-08 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/554#issuecomment-207539560 After chatting with @jpeach we agree on the goal here (to not retry if bytes were sent on the wire). I have updated the PR to include comments attempting to exp

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-08 Thread dragon512
Github user dragon512 commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-207522902 Looks good to me. However can we use namespaces? I mean ts_stl_iobuf_allocator!! it would better in my view to have namespace ts{ template

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-08 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-207486646 Wait, I thought Spdy was the only odd case that wasn't using iobufs already (due to the history of starting it out as a plugin and merging with the core later).

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-08 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-207478918 @zwoop @bcall no problem I'll update this with h2 as the example use case. @jpeach removing the TSDebug is no problem and I'm very open to naming suggestions...I re

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-08 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-207473198 There's a number of style issued here (use of ``TSDebug``) and I really think we can come up with better names than ``ts_stl_iobuf_allocator`` :) The idea

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-08 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-207463328 I agree with @zwoop, we have turned off spdy in prod and would rather see this in h2. --- If your project is set up for it, you can reply to this email and hav

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-08 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-207442936 Nice. Can you try it with the H2 code instead? SPDY is going away for 7.0, and is rather irrelevant, but it'd be super interesting to see what it does for H2, which

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-08 Thread bgaff
GitHub user bgaff opened a pull request: https://github.com/apache/trafficserver/pull/556 Adding STL Allocator which uses io bufs This is something that seems to come up at every summit and I always promise to prototype it. Ahead of the next summit I'd like to begin discussions aro

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature