Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-206137778
I just remembered tsqa. I'll try to write a test for this with tsqa.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206131655
@jpeach I didn't know we can use `TestBox.h` in Unit Tests:p I'll fix tests
to use it.
https://github.com/apache/trafficserver/blob/edf9ff13db4e63ee9b5003b
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-206128731
Though I tested it with nghttp and httpbin as an origin server, I think we
can test with nghttp/curl and nc. But if you mean automated tests, I have no
idea.
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206128440
@jpeach I agree with using many asserts is ugly. But if I understand
correctly, when we use `TestBox.h`, we need to write tests as Regression Tests.
Right?
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206113719
@masaori335 you can use ``TestBox.h`` for a simple regression test harness.
There's other examples of doing this in the tree. The test output is better and
you get
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-206111521
Is this testable? It seems like we really need a regression test here ...
---
If your project is set up for it, you can reply to this email and have your
reply app
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/551
TS-4321: Keep response headers in FetchSM as they are
https://issues.apache.org/jira/browse/TS-4321
You can merge this pull request into a Git repository by running:
$ git pull https://gi
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-206109679
Yah this makes sense :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206105027
Cool! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/537#issuecomment-206096251
@maskit Comparator is added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/550#issuecomment-206003272
Why is this logic still correct without testing ``parent_is_proxy``?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
GitHub user jrushf1239k opened a pull request:
https://github.com/apache/trafficserver/pull/550
TS-4327: Fix bug introduced with the addition of multi-site origin toâ¦
Fixe a segmentation fault when checking the parent_result.rec pointer
before it has been set by findParent(). See
12 matches
Mail list logo
