[GitHub] trafficserver pull request: TS-4274 Use the right hostdb levels as...

2016-03-23 Thread sekimura
GitHub user sekimura opened a pull request: https://github.com/apache/trafficserver/pull/536 TS-4274 Use the right hostdb levels as calling lookup_block With a wrong "levels" value, lookup_block() could return the wrong block. You can merge this pull request into a Git repositor

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-23 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-200354234 +1 on adding it to lib/ts. As for STL, the general rule is that if something runs on the critical path (e.g. as part of the HttpSM, or normal transaction handling),

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-23 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-200348327 @masaori335, yes exactly. It does look very generic already and it seems valuable to have in lib/ts. I can't think of anything offhand that would need it, but i

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-23 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-200337999 @PSUdaemon Yes, it is! It is one of reasons of implemented Http2PriorityQueue using template. Is it better to change name and move under `lib/ts/`? --- I

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-23 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-200325489 @zwoop Should we avoid STL in test code too? I used `ts/Vec.h` and implemented priority queue to avoid STL:D --- If your project is set up for it, you can rep