Re: trafficserver git commit: TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams

2016-03-22 Thread James Peach
> On Mar 21, 2016, at 6:57 PM, masa...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 1e9c9484c -> 0e6e5c151 > > > TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams > > Add below variables in records.config > - proxy.config.http2.mi

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-03-22 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/210#discussion_r57108812 --- Diff: plugins/experimental/ats_pagespeed/Makefile.am --- @@ -0,0 +1,72 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

Re: trafficserver git commit: New documentation for escalation plugin

2016-03-22 Thread James Peach
Hi Miles, Next time, would you mind splitting this into separate commits? That makes it easier to see what was fixed in the commit history ... > On Mar 22, 2016, at 2:41 PM, mlib...@apache.org wrote: > > Repository: trafficserver > Updated Branches: > refs/heads/master 41441da8e -> 015b77176 >

[GitHub] trafficserver pull request: TS-4284 Modernize the geoip_acl plugin

2016-03-22 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/535 TS-4284 Modernize the geoip_acl plugin There are two commits here: 1) Modernizes / refactors the plugin and 2) Adds IPv6 support I kept them as two separate

[GitHub] trafficserver pull request: TS-4280 Refactors the gzip plugin to i...

2016-03-22 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/534 TS-4280 Refactors the gzip plugin to improve hooks and memory usage This accomplishes three things: 1) Fix memory leak on config reload (ref-counting) 2) Reduces the number of

[GitHub] trafficserver pull request: TS-3639 Implement GeoIP information in...

2016-03-22 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/533 TS-3639 Implement GeoIP information into header_rewrite This adds a set of new GeoIP based conditions to the header_rewrite plugin, see the Examples/Geo file for an example. They can also be us

Re: [GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2016-03-22 Thread Alan Carroll
Another PR probably. This was really in the nature of an API review, I didn't actually write any of the code yet. On Tuesday, March 22, 2016 11:01 AM, zwoop wrote: Github user zwoop commented on the pull request:     https://github.com/apache/trafficserver/pull/272#issuecomment-199880

[GitHub] trafficserver pull request: Ts 4266: Added a GC in add module and ...

2016-03-22 Thread brkishore
GitHub user brkishore opened a pull request: https://github.com/apache/trafficserver/pull/532 Ts 4266: Added a GC in add module and delete module Refer Jira Ts 4266 for the issue and solution. The first 6 commits are garbage. They were just created when I was trying to dele

[GitHub] trafficserver pull request: TS-4287: Add a simple and dead server ...

2016-03-22 Thread jrushf1239k
Github user jrushf1239k commented on the pull request: https://github.com/apache/trafficserver/pull/530#issuecomment-200011630 Updated this pull request and renamed dead server retry to unavailable server retry. --- If your project is set up for it, you can reply to this email and ha

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-03-22 Thread oschaaf
Github user oschaaf commented on the pull request: https://github.com/apache/trafficserver/pull/210#issuecomment-23777 @zwoop thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/210#issuecomment-19165 Easiest is to look at the Jira, which has instructions how to merge and push. Make sure you "git pull --rebase" before you push upstream to ASF, otherwise the "Comm

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-03-22 Thread oschaaf
Github user oschaaf commented on the pull request: https://github.com/apache/trafficserver/pull/210#issuecomment-11263 Change looks good to me! What is the flow with regard to committing a pull request? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-03-22 Thread maskit
Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r57056410 --- Diff: proxy/http2/HPACK.cc --- @@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start, const uint8_t *buf_end, Http if (len

[GitHub] trafficserver pull request: AARCH64 fixes tested on Cavium Thunder...

2016-03-22 Thread shaygalon
Github user shaygalon commented on the pull request: https://github.com/apache/trafficserver/pull/502#issuecomment-199982414 For x86 you actually have to sign extend the lower bit otherwise on AMD systems you would be addressing the wrong address... The meaning of the bits >48 is arch

[GitHub] trafficserver pull request: TS-4285 Makes proxy.config.http.attach...

2016-03-22 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/531 TS-4285 Makes proxy.config.http.attach_server_session_to_client overridable EOM. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/traf

[REMINDER} CFP for 2016 ATS Spring Summit ends April 1st

2016-03-22 Thread Leif Hedstrom
Please submit your proposals for the ATS Spring summit, before April 1st (it’s no joke!). Send all proposals to summ...@trafficserver.apache.org Remember that this is a DevOps event, we encourage both developers, users and anyone interested in ATS and ATS related technologies to submit

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-03-22 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r57029193 --- Diff: proxy/http2/HPACK.cc --- @@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start, const uint8_t *buf_end, Http if (

[GitHub] trafficserver pull request: TS-4133: Update the url_sig plugin so ...

2016-03-22 Thread jrushf1239k
Github user jrushf1239k closed the pull request at: https://github.com/apache/trafficserver/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] trafficserver pull request: TS-4133: Update the url_sig plugin so ...

2016-03-22 Thread jrushf1239k
Github user jrushf1239k commented on the pull request: https://github.com/apache/trafficserver/pull/424#issuecomment-199902610 changes were pushed to master, closing this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] trafficserver pull request: TS-4287: Add a simple and dead server ...

2016-03-22 Thread jrushf1239k
Github user jrushf1239k commented on the pull request: https://github.com/apache/trafficserver/pull/530#issuecomment-199881433 Dead Server retry is confusing and not accurate. Change the configuration variable names and description to use unavailabe server retry. --- If your p

[GitHub] trafficserver pull request: Added (Estimated) Round Trip Time acce...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/123#issuecomment-199880892 @acaciocenteno Any chance you will work on this, and generalize this concept? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/272#issuecomment-199880458 @SolidWallOfCode You going to land this in this incarnation? Or another PR? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver pull request: API: Proposal for additional IO buffer...

2016-03-22 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-4032: Enable command line based mes...

2016-03-22 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-4042: Add feature to buffer request...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/351#issuecomment-199878590 ping on API review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] trafficserver pull request: Fix for TS-4276

2016-03-22 Thread jacksontj
Github user jacksontj closed the pull request at: https://github.com/apache/trafficserver/pull/526 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: Fix for TS-4276

2016-03-22 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/526#issuecomment-199878278 I don't want to merge this PR in, its a definite hack. I'm working on a better fix, it'll just take some time. --- If your project is set up for it, you can re

[GitHub] trafficserver pull request: AARCH64 fixes tested on Cavium Thunder...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/502#issuecomment-199877909 @PSUdaemon to review, the thought it as that at least the freelist bit mask is a clearer solution for all platforms. --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4240: fix coredump issues with esi ...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/503#issuecomment-199875223 @shukitchan Can you address Jame's comments, and then commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] trafficserver pull request: TS-4220 DNSHandler::mainEvent

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/493#issuecomment-199874748 @amc @scw00 It sounds like we should not commit this? If so, please close this. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-22 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-199873028 Is it possible to make the priority queue stuff more generic so it can be reusable? --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-199871552 @bryancall to review, if we land this with off by default it seems harmless. We do want to avoid STL when possible, but it is what it is :). --- If your project is

[GitHub] trafficserver pull request: Fix for TS-4276

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/526#issuecomment-199871069 @SolidWallOfCode to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] trafficserver pull request: Add TSSslContextCreate method

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/402#issuecomment-199870599 @biilmann Can you email something to the dev@ mailing list with the API proposal, for a review? See the link above for the process. --- If your project is set up f

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/210#issuecomment-199859557 @oschaaf Ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] trafficserver pull request: UUID Proposal

2016-03-22 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/199#issuecomment-199859179 Ping @acaciocenteno Are you still working / interested in this? We all want this, just needs a little tweaking, and generalize the UUID functionality to be a core c