Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/485
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/485#issuecomment-199581399
That is good point. This patch doesn't cover such cases.
> I think it would be better to dynamically adjust the max stream when a
new stream is created
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56920295
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if (len
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-199522681
Overall it looks good. I had a couple comments in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56910134
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,175 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE;
}
-
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56909414
--- Diff: proxy/http2/HPACK.h ---
@@ -90,31 +97,29 @@ class MIMEFieldWrapper
return _field;
}
+ bool
+ is_sensitive()
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56908946
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if (
GitHub user jrushf1239k opened a pull request:
https://github.com/apache/trafficserver/pull/530
TS-4287: Add a simple and dead server retry feature to Parent Selection.
@zwoop, @jpeach, @PSUdaemon, @bryancall please review and comment. This is
the simple retry and dead server retry
