[GitHub] trafficserver pull request: TS-4087: Reduce SETTINGS_MAX_CONCURREN...

2016-02-24 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/485#issuecomment-188585450 1. Removed `max_active_streams_per_thread_in` and related code. 2. Set default value of `proxy.config.http2.max_active_streams_in` 0 for backward compatibil

[GitHub] trafficserver pull request: TS-4087: Reduce SETTINGS_MAX_CONCURREN...

2016-02-24 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/485#discussion_r54039631 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -1160,3 +1162,31 @@ Http2ConnectionState::send_window_update_frame(Http2StreamId id, uint32_t s

[GitHub] trafficserver pull request: TS-4227: Remove auto_ptr in SPDY plugi...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4227: Remove auto_ptr in SPDY plugi...

2016-02-24 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/498#issuecomment-188494372 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] trafficserver pull request: TS-4227: Remove auto_ptr in SPDY plugi...

2016-02-24 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/498 TS-4227: Remove auto_ptr in SPDY plugin This only applies to 5.3.x and is because F22 has a version of GCC that has deprecated auto_ptr. You can merge this pull request into a Git reposito

[GitHub] trafficserver pull request: TS-4087: Reduce SETTINGS_MAX_CONCURREN...

2016-02-24 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/485#discussion_r54014800 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -1160,3 +1162,31 @@ Http2ConnectionState::send_window_update_frame(Http2StreamId id, uint32_t si

[GitHub] trafficserver pull request: TS-3938: Add hardening (fortify) as an...

2016-02-24 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/497#issuecomment-188403390 @jpeach Do you foresee any issues with doing a double hardening (distributions doing it and having it on by default)? --- If your project is set up for it

[GitHub] trafficserver pull request: TS-3938: Add hardening (fortify) as an...

2016-02-24 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/497#issuecomment-188402711 @dragon512 One benefit of doing the sed at the end of the process is that the FLAGS are in sync. Adding addition variables would require that we don't modi

[GitHub] trafficserver pull request: TS-3938: Add hardening (fortify) as an...

2016-02-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/497#issuecomment-188400207 > I think it would be better have an option for it. I agree it should be an option, but let's consider defaulting it to "on" for 7.0 --- If your project

[GitHub] trafficserver pull request: TS-3938: Add hardening (fortify) as an...

2016-02-24 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/497#issuecomment-188399695 I updated to remove `-fno-omit-frame-pointer`. @dragon512 Most distributions do hardening themselves. I think it would be better have an option for

[GitHub] trafficserver pull request: TS-3938: Add hardening (fortify) as an...

2016-02-24 Thread dragon512
Github user dragon512 commented on the pull request: https://github.com/apache/trafficserver/pull/497#issuecomment-188374276 The other question I would have is why would we not want -fPie enable for any compiler that supports it. --- If your project is set up for it, you can reply to

[GitHub] trafficserver pull request: TS-3938: Add hardening (fortify) as an...

2016-02-24 Thread dragon512
Github user dragon512 commented on the pull request: https://github.com/apache/trafficserver/pull/497#issuecomment-188371373 The sed command seems hacky to me. It would be clearer if we have a SHCXXFLAGS, etc ( ie Shared library flags or we can do the other way and make a PROGCXXFLAGS

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-02-24 Thread oschaaf
Github user oschaaf commented on the pull request: https://github.com/apache/trafficserver/pull/210#issuecomment-188185193 @bryancall yes. We've got some changes in our pipeline as well, I'll follow up shortly. --- If your project is set up for it, you can reply to this email and hav