Github user christoph-k86 commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-187040469
Yeah i know what you mean about that patch series... working on it
I just checked for configure to run in default configuration when looking
for tho
GitHub user scw00 opened a pull request:
https://github.com/apache/trafficserver/pull/493
TS-4220 DNSHandler::mainEvent
Dear all
failover_now return false when the name server's mark is not expiring, and
we need to call rr_failure to mark the name server as down.
Thx!!
You
GitHub user scw00 opened a pull request:
https://github.com/apache/trafficserver/pull/492
DNSHandler::mainEvent
Dear all
failover_now return false when the name server's mark is not expiring,
and we need to call rr_failure to mark the name server as down.
Thx!!
You
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186991246
> Feels hacky though.
Maybe something like jemalloc would be better solution to this problem as
@jpeach has suggested.
---
If your project is set up for i
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186988593
Duh. Sorry, looking too hard at malloc.
I have been trying to find macro we can use, but there isn't anything that
I can find that works well. This is h
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186980985
Ahh yes, you're correct @PSUdaemon . Nonetheless you cannot move the size_t
to the end because how would you find it given a raw pointer?
But @jpeach 's co
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186979652
@bgaff,
I think the 8 byte thing is a glibc implementation detail. Also, [this
link](http://www.delorie.com/gnu/docs/glibc/libc_31.html
) suggests i
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186976913
@PSUdaemon malloc guarantees 8 byte alignment, fwiw. This still perseveres
8 byte alignment assuming sizeof(size_t) remains 8 bytes.
---
If your project is set up
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186967151
@jpeach,
I can't speak to the relative ugliness of the code. It's fairly C-ish like
the rest of our memory related code.
I don't think the curr
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/484#issuecomment-186952120
Looks good. Merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186952049
Are you sure there isn't a better way to do this?
- it is fairly ugly
- it duplicates the allocation size tracking the allocator is already doing
-
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-186950232
This looks generally reasonable.
I'd like the patch series to be a bit cleaner; maybe fix the vagrant box
URLs in the first commit, then switch over to the
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/476
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/491#issuecomment-186934916
Looks reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/491
TS-4158 Adds appropriate releases of URL MLocs
The missing releases are benign, this is merely for correctness. There are
two misplaces printf()'s as well that I removed.
You can merge this pu
18 matches
Mail list logo
