[GitHub] trafficserver pull request: [TS-4095] adding a new example plugin ...

2016-02-18 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/393#issuecomment-186080875 I am :+1: as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request: [TS-4095] adding a new example plugin ...

2016-02-18 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/393#discussion_r53426210 --- Diff: doc/admin-guide/plugins/webp_transform.en.rst --- @@ -0,0 +1,38 @@ +.. _webp_transform: + +WebpTransform Plugin +**

[GitHub] trafficserver pull request: [TS-4095] adding a new example plugin ...

2016-02-18 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/393#issuecomment-186076071 Wow, yes this much cleaner by using ImageMagik. I'm :+1: with this. Anyone else have comments? --- If your project is set up for it, you can reply to this email an

[GitHub] trafficserver pull request: [TS-4095] adding a new example plugin ...

2016-02-18 Thread bgaff
Github user bgaff commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/393#discussion_r53425864 --- Diff: plugins/experimental/webp_transform/ImageTransform.cc --- @@ -0,0 +1,109 @@ +/** + Licensed to the Apache Software Foundation (ASF) und

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-18 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r53417506 --- Diff: proxy/http2/HTTP2.cc --- @@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers) return PARSE_DONE; }

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-18 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r53414542 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM *fetch_sm) Deb

[GitHub] trafficserver pull request: [TS-4095] adding a new example plugin ...

2016-02-18 Thread myraid
Github user myraid commented on the pull request: https://github.com/apache/trafficserver/pull/393#issuecomment-186013102 @bgaff can you review now. Using ImageMagick makes the code much cleaner. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-18 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r53414029 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM *fetch_sm) Deb

[GitHub] trafficserver pull request: TS-4190: Disabling LuaJIT in configure...

2016-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/486 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4190: Disabling LuaJIT in configure...

2016-02-18 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/486#issuecomment-185819952 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] trafficserver pull request: TS-4190: Disabling LuaJIT in configure...

2016-02-18 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/486 TS-4190: Disabling LuaJIT in configure still builds portions with Lua. Don't try to build Lua derived metrics support if we don't have any LuaJIT support. You can merge this pull request into

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-18 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/460#issuecomment-185757269 Also, this fixes a bug in the HPACK decoding process. Current decoding process stops if there is a HTTP2 violation (not HPACK violation) but it should not. As I co

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-18 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/460#issuecomment-185754698 @jpeach , I changed some function names as per your comments. But some are not exactly the same as you suggested because I think the names should correspond to the

[GitHub] trafficserver pull request: TS-4176: s3_auth add support for matri...

2016-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4087: Reduce SETTINGS_MAX_CONCURREN...

2016-02-18 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/485 TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams Add below variables in records.config - proxy.config.http2.min_concurrent_streams_in - proxy.config.http2.max_a