[GitHub] trafficserver pull request: TS-4162: Add proxy.config.http2.active...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4162: Add proxy.config.http2.active...

2016-02-01 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/444#issuecomment-178294038 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] trafficserver pull request: TS-4170: Error receiving data frame on...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4144: Add TSHttpTxnSetHttpRetStatus...

2016-02-01 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/435#issuecomment-178292993 Looks good to me. @bgaff Could you take a look this? If you're ok, I'll land this. --- If your project is set up for it, you can reply to this email and ha

[GitHub] trafficserver pull request: TS-4170: Error receiving data frame on...

2016-02-01 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/450 TS-4170: Error receiving data frame on closed connection for HTTP/2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficse

[GitHub] trafficserver pull request: TS-4170: Error receiving data frame on...

2016-02-01 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/450#issuecomment-178270734 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4165 Logging breaks if changing log...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4168: Only close inactive and activ...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/447 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4166: Memory leak in traffic_top

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4166: Memory leak in traffic_top

2016-02-01 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/445#issuecomment-178103313 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] trafficserver pull request: [TS-4160] Reset the txn request/respon...

2016-02-01 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/443#issuecomment-178064049 Agree - I don't particularly like caching these either, given that there's no guarantee offered (by the TS API) on the scope of these (the C plugins typically ac

[GitHub] trafficserver pull request: [TS-4160] Reset the txn request/respon...

2016-02-01 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/443#issuecomment-178061382 I'm having a major deja vu here :). We had this discussion at a summit, at LinkedIn, didn't we? :) Yeah, you have to be careful caching these, for these exact reaso

[GitHub] trafficserver pull request: TS-4168: Only close inactive and activ...

2016-02-01 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/447#issuecomment-178057937 +1, lets get this back ported to 6.1.1 as well (please mark the Jira accordingly). Although this might also need that other patch for the new timeout, right? If so,

[GitHub] trafficserver pull request: TS-4165 Logging breaks if changing log...

2016-02-01 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/446#discussion_r51428533 --- Diff: proxy/logging/LogObject.cc --- @@ -1043,6 +1044,15 @@ LogObjectManager::_solve_filename_conflicts(LogObject *log_object, int maxConfl