[GitHub] trafficserver pull request: [TS-4160] Reset the txn request/respon...

Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/443#issuecomment-176523513 @bgaff can you pls merge this and #442 together, once you review. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver pull request: [TS-4160] Reset the txn request/respon...

Github user myraid commented on the pull request: https://github.com/apache/trafficserver/pull/443#issuecomment-176522121 :+1: Need to make sure this goes along with #442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request: [TS-4135] fix redirect coredump

Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/442#issuecomment-176516828 :+1: but, need to go along with https://github.com/apache/trafficserver/pull/443 --- If your project is set up for it, you can reply to this email and have you

[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...

Github user dragon512 commented on the pull request: https://github.com/apache/trafficserver/pull/440#issuecomment-176508745 I agree with James in that the test are badly written. A better fix would be to use a real testing system. I working on that as well. It would be worse just to

[GitHub] trafficserver pull request: [TS-4160] Reset the txn request/respon...

GitHub user sudheerv opened a pull request: https://github.com/apache/trafficserver/pull/443 [TS-4160] Reset the txn request/response handles at each hook, since … …core may destroy them. @bgaff @myraid @boaz-r : please review You can merge this pull request into a Git

[GitHub] trafficserver pull request: [TS-4135] fix redirect coredump

Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/442#issuecomment-176504036 please review https://github.com/apache/trafficserver/pull/443 --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] trafficserver pull request: [TS-4135] fix redirect coredump

Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/442#issuecomment-176500044 This patch does not solve the issue completely (for example, the issues raised in https://issues.apache.org/jira/browse/TS-4160). You will also need to reset the

std library

Hi, I am using atscppapi to write my plugin. Can I use std::thread or should still use the low level TSThreadCreate for creating threads in my plugin? Thanks. Dnj

[GitHub] trafficserver pull request: [TS-4135] fix redirect coredump

GitHub user myraid opened a pull request: https://github.com/apache/trafficserver/pull/442 [TS-4135] fix redirect coredump @bgaff @shukitchan @sudheerv can you review. Removing TSMlocRelease is harmless as it s a no-op. Until we come up with a better way of cleanup lets not rel

[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...

Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/440#issuecomment-176484446 Ultimately I think you'd just want the values in file, one per line. But that's a bigger fix. --- If your project is set up for it, you can reply to this

[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...

Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/440#issuecomment-176480821 There is not really a good reason for these tests to store weird names in the filesystem. It just happened to be an easy way to do what I needed at the time. A bet

[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...

Github user meeramn commented on the pull request: https://github.com/apache/trafficserver/pull/440#issuecomment-176452436 Updated patch looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: clang format

Yep that did the trick Jason - Original Message - From: Jason Kenny To: "dev@trafficserver.apache.org" ; Alan Carroll Sent: Thursday, January 28, 2016 11:34 AM Subject: Re: clang format Ahh.. I did not use the magic version. Let me try to get this on my system correctly. Thanks Jas

Re: clang format

Ahh.. I did not use the magic version. Let me try to get this on my system correctly. Thanks Jason - Original Message - From: Alan Carroll To: "dev@trafficserver.apache.org" Sent: Thursday, January 28, 2016 11:32 AM Subject: Re: clang format Did you use Leif's magic clang[1]? Unfort

Re: clang format

Did you use Leif's magic clang[1]? Unfortunately clang apparently changes its formatting frequently and without recourse so you must use that precise version to be consistent. In general you should not see that many files changed. [1] https://bintray.com/apache/trafficserver/clang-format-tools/

[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...

Github user dragon512 commented on the pull request: https://github.com/apache/trafficserver/pull/440#issuecomment-176292994 Thanks. I have updated the patch with this fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

clang format

Hi, I was updating a patch by running clang-format. However when I ran this I noticed that I have a lot of files that are now different (50+ files). Should this be happening. I ran this on fedora 23. I would have thought I should only see changes in the one file I modified, ie taffic_via.cc.

[GitHub] trafficserver pull request: TS-4158: release mlocs correctly

Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/441#issuecomment-176227717 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable