[GitHub] trafficserver pull request: TS-4099: Implement Lua support for cus...

2016-01-17 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/422#discussion_r49960578 --- Diff: cmd/traffic_manager/metrics.cc --- @@ -0,0 +1,385 @@ +/** @file + * + * Traffic Manager custom metrics. + * + * @section

[GitHub] trafficserver pull request: TS-4099: Implement Lua support for cus...

2016-01-17 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/422#discussion_r49960411 --- Diff: lib/bindings/repl.cc --- @@ -0,0 +1,60 @@ +/** @file + * + * Lua bindings REPL. + * + * @section license License + *

[GitHub] trafficserver pull request: TS-4099: Implement Lua support for cus...

2016-01-17 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/422#discussion_r49959828 --- Diff: lib/bindings/repl.cc --- @@ -0,0 +1,60 @@ +/** @file + * + * Lua bindings REPL. + * + * @section license License

[GitHub] trafficserver pull request: TS-4099: Implement Lua support for cus...

2016-01-17 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/422#discussion_r49959792 --- Diff: cmd/traffic_manager/metrics.cc --- @@ -0,0 +1,385 @@ +/** @file + * + * Traffic Manager custom metrics. + * + * @sect

[GitHub] trafficserver pull request: [TS-4129] Support TSContSchedule in ts...

2016-01-17 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/420#issuecomment-172416165 I just updated the pull request. @jpeach, pls take a look. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request: TS-4140 Fixes a coverity warning due t...

2016-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/427 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Ts 4142

2016-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4140 Fixes a coverity warning due t...

2016-01-17 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/427#issuecomment-172394940 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] trafficserver pull request: Ts 4142

2016-01-17 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/428 Ts 4142 This fixes builds on OmniOS. I split this up into two commits, since not everything can be cherry-picked to 6.1.x You can merge this pull request into a Git repository by running:

[GitHub] trafficserver pull request: TS-4140 Fixes a coverity warning due t...

2016-01-17 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/427 TS-4140 Fixes a coverity warning due to changes in TS-4106 (dead code) This restores an older behavior, removing an unnecessary conditional (dead code).q can never be NUL.. You can merge this

[GitHub] trafficserver pull request: TS-4139: Send GOAWAY if it failed to c...

2016-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/426 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4139: Send GOAWAY if it failed to c...

2016-01-17 Thread maskit
GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/426 TS-4139: Send GOAWAY if it failed to change stream state This is a fix for CID 1347871: Unchecked return value You can merge this pull request into a Git repository by running: $ git pull