[GitHub] trafficserver pull request: TS-4134: Fix privilege elevation issue...

2016-01-15 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/425#issuecomment-172158012 This looks OK to me, though I would have preferred a smaller diff. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver pull request: [TS-4129] Support TSContSchedule in ts...

2016-01-15 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/420#issuecomment-172102643 nice catch on both cases. let me update the PR over the weekend after some tests on the new code. --- If your project is set up for it, you can reply to this

[GitHub] trafficserver pull request: TS-4104: return 1 on a new ticket crea...

2016-01-15 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/400#issuecomment-172061089 With and without the return code change I get: [Jan 15 11:27:31.471] Server {0x7f231793e840} DEBUG: (ssl) create ticket for a new session. [Jan 15 11:27:

[GitHub] trafficserver pull request: Add TSSslContextCreate method

2016-01-15 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/402#issuecomment-171990184 Yes, I agree that having a matching TSSslContextDestroy is a good idea even if it is just a wrapper for the openssl call at this point. I also like the i