Github user biilmann commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-168927960
Changed the type signature to `TSSslContextCreate(void)` now.
It generally makes sense that a plugin that needs this method will want to
handle the call
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168899579
ha. my bad english
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168899277
Oh I see, that makes sense. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168898944
@jpeach
Before the change the lua number is always an integer (e.g. 1451970346).
Now after the change the lua number will contain the fraction of the secon
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/402#issuecomment-168898043
This looks pretty reasonable to me. @shinrich, what do you think?
In ``ts/ts.h``, ``TSSslContextCreate()`` needs to be
``TSSslContextCreate(void)``.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-168897717
I don't see any code that logs when the specified ``resolve.conf`` fails to
load. Is there anything?
---
If your project is set up for it, you can reply to this e
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-168897439
@jpeach what "failure" are you referring to when we load resolve.conf?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-168897199
@bgaff I'm suggesting that the error should be emitted at the point where
we detect the failure.
---
If your project is set up for it, you can reply to this email
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-168897096
@zizhong yah an Error might be more appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168896100
I guess I still don't get it. This API already returned a Lua number, so
the only semantic change I can see is that there is no longer any potential
issue with tru
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-168895362
To @zwoop's comment, I can't see any obvious warning. This patch adds a
warning ``There is no name server found in the resolv.conf`` sometime after it
fails to loa
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168871196
@jpeach
Yes. the time is still in seconds. But instead of returning an integer all
the time, it is now a "lua_Number", which is like a "double".
GitHub user hnakamur reopened a pull request:
https://github.com/apache/trafficserver/pull/404
Fix a typo in traffic_via command reference
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hnakamur/trafficserver patch-1
Alternativ
Github user hnakamur closed the pull request at:
https://github.com/apache/trafficserver/pull/404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-168861430
Any other questions about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-168846815
@bgaff I reused some of the code from libwebp examples and so there is a
mix of C and C++. I will check if Imagemagick can be used to abstract image
specific detai
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168836153
This still returns time in seconds, since the arithmetic is the same. If
you change the time units should you add a new API to preserve compatibility?
---
If your
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/298#issuecomment-168814793
Closed. Was merged by jpeach on Oct 22, 2015.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jrushf1239k closed the pull request at:
https://github.com/apache/trafficserver/pull/298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168799362
@jpeach , can you take a quick look on this as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168776716
Why do you put the message in square brackets? That seems unusual. +1 at
any rate.
---
If your project is set up for it, you can reply to this email and have your
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168776257
so given that, is this one ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168776170
see https://issues.apache.org/jira/browse/TS-4110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168775306
That's correct. I think we should keep this fix and have another jira for
that problem in TSDebug.
---
If your project is set up for it, you can reply to this
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168721925
So it is a bug in ``TSDebug`` then? Can we fix that instead or as well?
---
If your project is set up for it, you can reply to this email and have your
reply appea
28 matches
Mail list logo
