[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-22 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/397#issuecomment-166795111 I just meant that I didn't see it used in this patch. Did I look in the right place? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-22 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/397#issuecomment-166794993 It lets the C++ API lock a mutex that is contained in a continuation in a scoped fashion. The already existing mutex locking mechanisms handle mutexes via

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-22 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/397#issuecomment-166789440 What is ```ScopedContinuationLock``` for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request: TS-3235: fix crash problem caused by s...

2015-12-22 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/397 TS-3235: fix crash problem caused by sync problem in PluginVC. This is an updated version of PR 164 that has been tested in production. It attempts to fix the related issue in the C++

[GitHub] trafficserver pull request: Remove the extra semicolon

2015-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: [TS-4095] adding a new example plugin ...

2015-12-22 Thread myraid
Github user myraid commented on the pull request: https://github.com/apache/trafficserver/pull/393#issuecomment-166764391 @bgaff I made the suggested changes. Also added license agreement. @shukitchan I am working on c-lang formatting and update the PR. --- If your projec

[GitHub] trafficserver pull request: [TS-4095] adding a new example plugin ...

2015-12-22 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/393#issuecomment-166739688 2 more comments 1) Please add an ASF license blurb to all new files 2) you can also run clang-format to beautify your code a bit as well. Check out

[GitHub] trafficserver pull request: TS-4097: Encode empty string properly ...

2015-12-22 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/395#issuecomment-166713566 I am getting this ASAN error running regressions with this pull request: REGRESSION TEST HPACK_EncodeString started =