Re: [trafficserver] TS-3418: Second hash ring for consistently hashed parent selection (#359)

2015-12-11 Thread Rushford, John
James, I squashed in a final with these changes, you might wish to clone the branch again. 1. I fixed the ownership concern. It helps having someone else review your code, thanks very much for that! 2. I kept the round_robin flag. As the implementation differences between no round robi

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-11 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-164002946 Updated with url_len removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-11 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-163998438 @jrushf1239k I think this will land before #359, so you will have to rebase. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-11 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-163997300 There was a lot of redundant or plainly wrong code in there. Like we treated round_robin as a boolean and as an enum. Also a little bit of added NULL ch

[GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...

2015-12-11 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/369#issuecomment-163996272 Looks good to me now, +1. It's a little difficult to decipher the refactoring in ParentRecord::FindParent, I assume that's mostly optimizations? --- If your projec