[GitHub] trafficserver pull request: TS-4018: Use HPACK huffman encoding al...

2015-12-03 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/362#issuecomment-161873548 FYI it is better to squash the format commits rather than have them appear separately. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request: TS-3960: traffic_line -x doesn't reloa...

2015-12-03 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/301#issuecomment-161872963 This looks pretty good. in a previous comment I suggested sending a flags field with the child rollback registration. Maybe that could be a way to request that the

[GitHub] trafficserver pull request: TS-4018: Use HPACK huffman encoding al...

2015-12-03 Thread maskit
GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/362 TS-4018: Use HPACK huffman encoding always https://issues.apache.org/jira/browse/TS-4018 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ma

[GitHub] trafficserver pull request: TS-4050 - Trafficserver is crashing wh...

2015-12-03 Thread meeramn
GitHub user meeramn opened a pull request: https://github.com/apache/trafficserver/pull/361 TS-4050 - Trafficserver is crashing when buckets=0 is configured in cache_promote plugin Fix trafficserver crash when buckets=0 is configured in cache_promote plugin and Set buckets default

[GitHub] trafficserver pull request: TS-4050 - Trafficserver is crashing wh...

2015-12-03 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/361#issuecomment-161826127 Much better! I'll have to check / read the code more thoroughly, but are you sure this isn't now leaking the object when the freelist is empty?

[GitHub] trafficserver pull request: TS-4050 - Trafficserver is crashing wh...

2015-12-03 Thread meeramn
Github user meeramn closed the pull request at: https://github.com/apache/trafficserver/pull/360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4050 - Trafficserver is crashing wh...

2015-12-03 Thread meeramn
Github user meeramn commented on the pull request: https://github.com/apache/trafficserver/pull/360#issuecomment-161822868 Closing this. I will open new pull request with actual changes --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] trafficserver pull request: TS-4050 - Trafficserver is crashing wh...

2015-12-03 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/360#issuecomment-161801444 Hmmm, I'll have to review this further, but there seems to be a lot other changes here in this PR, unrelated to this actual fix. Why is that? Why is so much code ch

[GitHub] trafficserver pull request: TS-4050 - Trafficserver is crashing wh...

2015-12-03 Thread meeramn
GitHub user meeramn opened a pull request: https://github.com/apache/trafficserver/pull/360 TS-4050 - Trafficserver is crashing when buckets=0 is configured in cache_promote plugin Fix trafficserver crash when buckets=0 is configured in cache_promote plugin and Set buckets default

Re: [VOTE] Release Apache Traffic Server 6.0.1 (RC0)

2015-12-03 Thread Bryan Call
+1 - Running in production under ASAN on RHEL 7.1 without any issues. Also, built and tested on Fedora 23. -Bryan > On Dec 2, 2015, at 3:54 PM, Bryan Call wrote: > > I've prepared a release for 6.0.1 (RC0) which is the next bug fix version of > Apache Traffic Server. This is detailed in

[GitHub] trafficserver pull request: doc: fix links of admin-guide

2015-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature