Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ushachar commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-161205132
To quote our own docs (under Admin Guide/Plugins):
"""
One of the key features of Apache Traffic Server⢠is its modularity.
Features that arenât neede
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/324#issuecomment-161188083
This is getting closer. Please rebase your changes onto latest master and
force push the branch to refresh.
There are a number of places that still need to
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/324#issuecomment-161184930
@jpeach , if you're good, I'll land this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/324#issuecomment-161183921
I filed this as [TS-4047](https://issues.apache.org/jira/browse/TS-4047).
---
If your project is set up for it, you can reply to this email and have your
reply app
> On Dec 1, 2015, at 4:28 PM, Leif Hedstrom wrote:
>
> One more thing to consider:
>
> How do we coordinate reviews such that we don't do major duplication? It's
> good to have more tha one reviewer (on complicated), but we simple don't have
> the resources sub that every PR gets a large numb
One more thing to consider:
How do we coordinate reviews such that we don't do major duplication? It's good
to have more tha one reviewer (on complicated), but we simple don't have the
resources sub that every PR gets a large number of reviewers.
At a previous place I've been, each PR was assig
> On Dec 1, 2015, at 9:28 AM, James Peach wrote:
>
>
>> On Nov 30, 2015, at 10:55 AM, Leif Hedstrom wrote:
>>
>> Now that we agreed to use Github as a patch / review board, the question is:
>> Where do we post comments? On the Jira, or the Github pull request? My
>> preference is constantly
Github user jaaju commented on the pull request:
https://github.com/apache/trafficserver/pull/324#issuecomment-161077650
@bgaff, @jpeach
I have incorporated James' feedback and resolved conflicts by merging
changes from upstream. Let me know if this is good. Thanks!
---
If your
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-161034092
Originally, I just had an int pointer for the flags. Then we were doing
experiments with multiple flags, and it seemed like having a separate class
with bit nam
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-161030286
Yeh I mean the latter. All the code in ```ContFlags``` boils down to
getspecific + setspecific, the rest is really not necessary. A separate file
with a class that
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-161026974
James - a `uintptr_t` instead of `ContFlags` would require the assumption a
continuation always runs on the same thread, which is not the case. `ContFlags`
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-161024984
The whole ```ContFlags``` class seems unnecessary. If you really need
per-thread flags, then why not just keep a thread-specify ```uintptr_t``` in
the ```Continuat
> On Nov 30, 2015, at 10:55 AM, Leif Hedstrom wrote:
>
> Now that we agreed to use Github as a patch / review board, the question is:
> Where do we post comments? On the Jira, or the Github pull request? My
> preference is constantly using Jira, for two reasons
>
> 1) Our automated release no
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-161019315
Message marshaling works just fine, see #301 for an example of exactly what
you want to do here. If you can show me the problem then I can try to help.
---
If you
I have a PR out for TS-3072 "Debug logging for a single connection".
https://github.com/apache/trafficserver/pull/350
So far there is general agreement that this is a useful feature.
However, there is contention on how this feature is activated. The
current proposed implementation uses the exi
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160998970
I need to work on the documentation a bit more before I send it out for
formal API review. I would also like to build better example / use case code.
It m
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160998361
I hand marshall the message from `traffic_manager` to `traffic_server`
because the technique you suggest did not work for me. What I did was pass the
raw
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/357#issuecomment-160906831
@bgaff - updated with using macro. thank.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/357#discussion_r46250788
--- Diff: plugins/experimental/ts_lua/ts_lua_client_request.c ---
@@ -332,6 +348,10 @@ ts_lua_client_request_get_pristine_url(lua_State *L)
ts_lua_
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/357#issuecomment-160890632
@jpeach , would really appreciate if you can take a look and review.
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/357
TS-4045: ts_lua improvements
3 things to accomplish in this jira
1) add support for TSHttpTxnDebugSet
2) protect http context pointer access in api calls
3) fix a spelling
23 matches
Mail list logo
