[GitHub] trafficserver pull request: TS-4038: Redundant `isdigit(b)` in `Lo...

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/347 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Ts 3559

2015-11-23 Thread repodude
Github user repodude commented on the pull request: https://github.com/apache/trafficserver/pull/232#issuecomment-159095402 Yeah, bummer we weren't able to sync up at ATS summit as I think it might be helpful to clarify some of this application's requirements and/or divulging the run-

[GitHub] trafficserver pull request: TS-4040: Adding the missing `va_end(.....

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4032: Enable command line based mes...

2015-11-23 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/343#issuecomment-159090606 > I thought I saw a comment from James but it doesn't seem to be there now. I think I made them on the JIRA. > 1) I'm open to using a term other th

[GitHub] trafficserver pull request: TS-4032: Enable command line based mes...

2015-11-23 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/343#issuecomment-159058332 I thought I saw a comment from James but it doesn't seem to be there now. 1) I'm open to using a term other than "alert", if there are any specific

[GitHub] trafficserver pull request: TS-4040: Adding the missing `va_end(.....

2015-11-23 Thread canselcik
GitHub user canselcik opened a pull request: https://github.com/apache/trafficserver/pull/349 TS-4040: Adding the missing `va_end(...)` statements to `Diags.cc` and `wccp-test-router.cc` Adding the needed va_end(...) statements. @bgaff You can merge this pull reques

[GitHub] trafficserver pull request: TS-4039: StreamHashTable::deleteStaleS...

2015-11-23 Thread canselcik
GitHub user canselcik opened a pull request: https://github.com/apache/trafficserver/pull/348 TS-4039: StreamHashTable::deleteStaleStreams doesn't initialize an int primitive to zero before iterating Properly initializing the `int i` to `0` in `StreamHashTable::deleteStaleStreams(t

[GitHub] trafficserver pull request: TS-4038: Redundant `isdigit(b)` in `Lo...

2015-11-23 Thread canselcik
GitHub user canselcik opened a pull request: https://github.com/apache/trafficserver/pull/347 TS-4038: Redundant `isdigit(b)` in `LogFormat::parse_escape_string Simple fix that shouldn't have any side effects since isdigit is not changing the value of b. @bgaff You can me