Re: Question about NetHandler::mainNetEvent and PollCont::pollEvent

2015-11-02 Thread Chao Xu
PollCont is a part of UDP implement, the PollCont is directly put into ET_UDP. UnixUDPNet.cc: thread->schedule_every(get_UDPPollCont(thread), -9); we will duplicate the polling code again on UDP implement if remove PollCont entirely. I think the Author of PollCont design it for UDPNetHandler an

[GitHub] trafficserver pull request: Documentation reorganization

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Jira TS-3932 IP TOS field not set.

2015-11-02 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/318 Jira TS-3932 IP TOS field not set. For Jira TS-3932, added second call to Connection::apply_options() within Connection::connect() so that the IP TOS field will be set properly. The first cal

Re: Question about NetHandler::mainNetEvent and PollCont::pollEvent

2015-11-02 Thread Alan Carroll
I've been looking at that and my preference would be to remove PollCont entirely. As far as I can tell it exists only to hold the poll descriptor data which could easily be promoted to NetHandhandler. On Monday, November 2, 2015 8:14 AM, Chao Xu wrote: Hi, All! I'm looking into t

[GitHub] trafficserver pull request: TS-306 Enable log rotation for diags.l...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Question about NetHandler::mainNetEvent and PollCont::pollEvent

2015-11-02 Thread Chao Xu
Hi, All! I'm looking into the iocore source code reading now. I found the source code from PollCont::pollEvent() is a part of NetHandler::mainNetEvent() . And the PollCont is designed to as a abstract class for I/O polling operation. so I have a question: why we duplicate the code in mainNetEve