Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/300#issuecomment-145744298
Any other comments on the implementation before I land it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/300#issuecomment-145743518
After looking into this, testing doesn't really make sense in a regression
test so what i'll do is just drop in another source file called parser_tests.cc
and have
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/300#issuecomment-145712386
@zwoop yah unit tests should be pretty easy to add.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/300#issuecomment-145669029
it ought to be possible to make a standalone test program, that exercises
the config loading / parsing, without having to run as a plugin. Basically,
something that
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/300#issuecomment-145649988
I think we need tests for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/300#issuecomment-145647206
This looks reasonable. I'm not surprised that the existing code is broken.
I wrote it in a hurry to be able to remove Boost but I guess I didn't test
variations
Hi all,
The RTD documentation build was failing somewhere in a Python Latex module. I
could not reproduce it locally, so I turned off the PDF and ePUB outputs on
readthedocs.org and it is now building OK. I also enabled build failure
notifications, so next time the documentation build starts fa
GitHub user bgaff opened a pull request:
https://github.com/apache/trafficserver/pull/300
TS-3956: Header_rewrite applies strange logic with = operator
Please see ticket TS-3956 for more information, I'm using github here so
that @zwoop / @jacksontj can provide a code review.
