[GitHub] trafficserver pull request: TS3848

2015-08-24 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/280#issuecomment-134467459 While I think that using the `cache.http` override for transaction level caching control is bad design, it is nonetheless the current design and I must ag

Re: [GitHub] trafficserver pull request: TS3848

2015-08-24 Thread Pushkar Pradhan
1. I wanted to limit the scope of this ticket to only detect disk failures in initialization.2. I haven't verified that individual plugins can override the   proxy.config.http.cache.http but assuming that is true maybe we can allow this exception since we cannot check run time plugin requirements

[GitHub] trafficserver pull request: TS3848

2015-08-24 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/280#issuecomment-134423458 Some questions/comments: 1) What happens when one or more disks fail during run time? The setting name *proxy.config.http.cache.required* seems too confusing/

[GitHub] trafficserver pull request: TS3848

2015-08-24 Thread pushkarpradhan
GitHub user pushkarpradhan opened a pull request: https://github.com/apache/trafficserver/pull/280 TS3848 Fixes TS-3848. A new variable proxy.config.http.cache.required (range: 0-2) controls whether we will exit on cache or volume initialization failure. 0 Continue serv

[GitHub] trafficserver pull request: TS3848

2015-08-24 Thread pushkarpradhan
Github user pushkarpradhan commented on the pull request: https://github.com/apache/trafficserver/pull/279#issuecomment-134404937 Please ignore for now, found a null pointer access. Will fix and create a new PR shortly. --- If your project is set up for it, you can reply to this

[GitHub] trafficserver pull request: TS3848

2015-08-24 Thread pushkarpradhan
Github user pushkarpradhan closed the pull request at: https://github.com/apache/trafficserver/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

RE: Pull request for TS-3848

2015-08-24 Thread Pushkar Pradhan
Hello,Please review my pull request:TS3848 by pushkarpradhan · Pull Request #279 · apache/trafficserver |   | |   | |   |   |   |   |   | | TS3848 by pushkarpradhan · Pull Request #279 · apache/...This is a proposed fix for TS-3848. The idea is that if traffic_server fails to read/initialize o

[GitHub] trafficserver pull request: TS3848

2015-08-24 Thread pushkarpradhan
GitHub user pushkarpradhan opened a pull request: https://github.com/apache/trafficserver/pull/279 TS3848 This is a proposed fix for TS-3848. The idea is that if traffic_server fails to read/initialize one or more cache disks or volumes we should fail. This is configurable