Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/276#issuecomment-130510960
Result of h2spec with this patch.
```
...
68 tests, 65 passed, 1 skipped, 2 failed
Github user syucream commented on the pull request:
https://github.com/apache/trafficserver/pull/277#issuecomment-130503083
@jacksontj Hi, I fixed my patch for tsqa test cases. please take another
look.
---
If your project is set up for it, you can reply to this email and have your
r
GitHub user syucream opened a pull request:
https://github.com/apache/trafficserver/pull/277
TS-3782: Add H2 exceptional test cases
HTTP/2 exceptional test cases. It has already been fixed based on comments
on [TS-3782](https://issues.apache.org/jira/browse/TS-3782)
You can merge t
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130491241
@ushachar Ah, so the argument is to not add special handling for this, but
still allow them to be used in ip_allow.config? If so, that seems fine.
---
If your proj
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130400491
I'm going to side with Uri on this one as well. Adding those to the core
HTTP method list seems wrong to me. As I understand, the real goal here is just
f
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-130400177
Thanks for all the input, I appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/274#issuecomment-130386828
That's all my comments for now, looking much better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36889035
--- Diff: proxy/Makefile.am ---
@@ -46,7 +46,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/mgmt \
-I$(top_srcdir)/mgmt/utils \
-I$(top_srcdir
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36888489
--- Diff: proxy/Makefile.am ---
@@ -46,7 +46,7 @@ AM_CPPFLAGS = \
-I$(top_srcdir)/mgmt \
-I$(top_srcdir)/mgmt/utils \
-I$(t
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36887236
--- Diff: lib/ts/Diags.h ---
@@ -36,12 +36,14 @@
#define __DIAGS_H___
#include
-#include "ts/ink_error.h"
-#include "ts
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36885521
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section license L
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36883442
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36883269
--- Diff: lib/ts/BaseLogFile.cc ---
@@ -0,0 +1,578 @@
+/** @file
+
+ Base class for log files implementation
+
+ @section
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36881681
--- Diff: iocore/eventsystem/test_Buffer.cc ---
@@ -91,23 +91,13 @@ reconfigure_diags()
static void
init_diags(const char *bdt, const
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/274#discussion_r36881282
--- Diff: doc/reference/configuration/records.config.en.rst ---
@@ -214,6 +214,28 @@ A value of ``0`` means no signal will be sent.
The
This has multiple, independent changes, so it should have been a series of
separate commits. I think it is also worth referencing the Coverity CID (I
assume that this fixes a number of them?)
> On Aug 11, 2015, at 2:18 PM, a...@apache.org wrote:
>
> Repository: trafficserver
> Updated Branches
Github user ushachar commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-130198618
I'm not advocating rejecting all non-standard methods out of hand -- I'm
just saying they don't belong in our recognized method list.
As a general approach, I
17 matches
Mail list logo
