Re: [IMPORTANT] Procedure around committing pull requests (and commits in general)

2015-07-10 Thread Thomas Jackson
+1 for automatic tests on PRs :D We'd have to check with leif on what the jenkins budget looks like, but I think its probably reasonable to run a subset of the tests on PRs. I'm thinking: - build - regression - make test - tsqa All on a centos box (since thats the minimum required pl

Re: STL and ATS (not sitting in a tree ...)

2015-07-10 Thread Nick Kew
On Fri, 10 Jul 2015 13:41:52 -0600 Leif Hedstrom wrote: > Hi all, > > this is just a gentle reminder: > > > We don’t use STL generally. There are exceptions, but unless there are truly > good reasons for it, just don’t use it. Even if it’s not on the critical > path. We have plenty of contai

[GitHub] trafficserver pull request: TS-3757 Update documentation to includ...

2015-07-10 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/248 TS-3757 Update documentation to include periodic_tasks_interval TS-3435 added the new config variable. You can merge this pull request into a Git repository by running: $ git pull https:/

STL and ATS (not sitting in a tree ...)

2015-07-10 Thread Leif Hedstrom
Hi all, this is just a gentle reminder: We don’t use STL generally. There are exceptions, but unless there are truly good reasons for it, just don’t use it. Even if it’s not on the critical path. We have plenty of containers and tools to do similar things. Yes, they are not as “neat” as STL,

Re: [IMPORTANT] Procedure around committing pull requests (and commits in general)

2015-07-10 Thread Bret Palsson
Anyone have a problem with me adding in support to run these tests automatically when a pull request comes in? I can leverage Jenkins to do this. -Bret On Friday, July 10, 2015, James Peach wrote: > > > On Jul 10, 2015, at 11:21 AM, Leif Hedstrom > wrote: > > > > Hi all, > > > > since we’re se

Re: [IMPORTANT] Procedure around committing pull requests (and commits in general)

2015-07-10 Thread James Peach
> On Jul 10, 2015, at 11:21 AM, Leif Hedstrom wrote: > > Hi all, > > since we’re seeing a pretty significant increase in pull requests (primarily > from github), I’d like to remind everyone about some guidelines for > committing and testing. This applies to both commits you make on someone >

[IMPORTANT] Procedure around committing pull requests (and commits in general)

2015-07-10 Thread Leif Hedstrom
Hi all, since we’re seeing a pretty significant increase in pull requests (primarily from github), I’d like to remind everyone about some guidelines for committing and testing. This applies to both commits you make on someone else’s pull request, as well as to your own commits. 1. Make sure to

[GitHub] trafficserver pull request: TS-3537 Update documentation to includ...

2015-07-10 Thread danobi
Github user danobi closed the pull request at: https://github.com/apache/trafficserver/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3537 Update documentation to includ...

2015-07-10 Thread danobi
Github user danobi commented on the pull request: https://github.com/apache/trafficserver/pull/247#issuecomment-120466390 Oops, wrong issue number --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] trafficserver pull request: TS-3537 Update documentation to includ...

2015-07-10 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/247 TS-3537 Update documentation to include periodic_tasks_interval TS-3435 added the new config variable. You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] trafficserver pull request: Add ListAll for HostDB httpui endpoint

2015-07-10 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/245#discussion_r34371196 --- Diff: iocore/hostdb/HostDB.cc --- @@ -1801,6 +1828,39 @@ HostDBContinuation::do_put_response(ClusterMachine *m, HostDBInfo *r, Continuati

[GitHub] trafficserver pull request: Add ListAll for HostDB httpui endpoint

2015-07-10 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/245#discussion_r34371142 --- Diff: iocore/hostdb/HostDB.cc --- @@ -1037,6 +1037,33 @@ HostDBProcessor::getbyname_imm(Continuation *cont, process_hostdb_info_pfn proce

[GitHub] trafficserver pull request: TS-3435 Make Log.cc:PERIODIC_TASKS_INT...

2015-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: [TS-3476] Add a log tag for applicatio...

2015-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3534 Wiretracing SSL Connections

2015-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature