[GitHub] trafficserver pull request: TS-3693: Move 100-continue logic to re...

2015-06-28 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/216#issuecomment-116437793 @jacksontj sounds like it should be fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-06-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/218#issuecomment-116361206 Overall I think the log tags are useful in ways aggregate statistics are not and I support adding those tags. --- If your project is set up for it, you c

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-06-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/218#discussion_r33428565 --- Diff: doc/reference/api/TSNetVConnSSLCachedHitSet.en.rst --- @@ -0,0 +1,32 @@ +.. Licensed to the Apache Software Foundation (ASF) under

[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...

2015-06-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/218#discussion_r33428474 --- Diff: doc/admin/event-logging-formats.en.rst --- @@ -170,6 +170,24 @@ The following list describes Traffic Server custom logging fields.