[GitHub] trafficserver pull request: TS-3486: Crashes due to race condition...

2015-06-26 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/235 TS-3486: Crashes due to race condition on server sessions moving betw… …een threads. Addressing crash issues disucssed in TS-3266 and TS-3486. This fix has been running on Y! 5

[GitHub] trafficserver pull request: TS-2150: Add Milestone log tags

2015-06-26 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/229#issuecomment-115746373 I think it would be better at the creation of the LogField store the index into the milestone array instead of looking it up every time you log. You can create

[GitHub] trafficserver pull request: Integration test for TLS ticket key ro...

2015-06-26 Thread zeb209
Github user zeb209 commented on the pull request: https://github.com/apache/trafficserver/pull/189#issuecomment-115743209 @jacksontj is there any technical reason why this pull request has not been merged? --- If your project is set up for it, you can reply to this email and have you

TS-2150 and PR 229

2015-06-26 Thread Alan Carroll
I've been working with Francios on this and it looks ready to commit as far as I am concerned. This seemed to be a bit contentious so I want to have this last opportunity to speak up before I ship it (it will go in 6.1).

[GitHub] trafficserver pull request: TS-2150: Add Milestone log tags

2015-06-26 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/229#issuecomment-115738793 Ready to ship. The only tweak I'd recommend now is to put a reference to `TSHttpTxnMilestoneGet` in the documentation update so there's a link to the list

[GitHub] trafficserver pull request: Integration test for TLS ticket key ro...

2015-06-26 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/189#issuecomment-115730361 @zwoop we can if you want, but these are all just adding tests for features that already exist-- So I would lean towards not requiring tickets. --- If your pro

[GitHub] trafficserver pull request: TS-3693: Move 100-continue logic to re...

2015-06-26 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/216#issuecomment-115726377 @bgaff Does this play nice with our double plugin execution fix? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver pull request: add init test for SSL Termination

2015-06-26 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/192#issuecomment-115725233 @PSUdaemon Yea, i can commit this-- there's just a merge conflict :). @ffcai Do you want to do the merge? Or should I? --- If your project is set up for it, yo