[GitHub] trafficserver pull request: Integration test for TLS ticket key ro...

2015-04-30 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/189#issuecomment-98012180 @zeb209 Per our offline discussion we can add the tests for assigning a key out of the middle later. Before we merge this in though, can you do a git mv and a sq

[GitHub] trafficserver pull request: add init test for SSL Termination

2015-04-30 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/192#issuecomment-98012067 @ffcai Assuming the tests still pass that should be fine :) I just finished replacing the old tsqa-- so sadly you now have a merge conflict :( --- If

Re: [v6.0.0] Experimental Plugins -> Stable

2015-04-30 Thread Miles Libbey
I'm not sure I'd believe a plugin was ready to be moved out of experimental if it doesn't have a documentation page (eg, other than a README in the code directory, though the doc page wouldn't have to have different content).miles On Wednesday, April 29, 2015 9:15 PM, Steven Hunter wrote:

Re: [v6.0.0] Experimental Plugins -> Stable

2015-04-30 Thread Steven Hunter
Stable_connection/ StevenHunter On Apr 24, 2015 11:09 AM, "Leif Hedstrom" wrote: > > Hi all, > > Below is a list of currently “experimental” plugins. We should decide which, if any, of these should be moved to a stable state. Once stable, incompatible changes within a major release would not be a

[GitHub] trafficserver pull request: Ts 3534

2015-04-30 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/194#issuecomment-97845539 I agree with @jpeach on the TCP_INFO usage. Are the TCP_INFO traces even part of the wire trace feature? Besides being non-portable, isn't there also (significant

[GitHub] trafficserver pull request: Ts 3534

2015-04-30 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/194#issuecomment-97840771 I only looked quickly, but just a couple of points. The use of ``TCP_INFO`` is non-portable so this feature will need to be conditional. Why would we have our own t

[GitHub] trafficserver pull request: TS-3538: perform server certificate va...

2015-04-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature