Re: [VOTE] Release v5.2.1

this may have been a bit premature :| https://gist.github.com/igalic/875134e7b6ee35f252c4 - On 25 Mar, 2015, at 02:08, Igor Galić i.ga...@brainsware.org wrote: > this looks good, i.e.: it fixes the assert. > +1 from me. > > > > caveat: i had to wipe my cache for it to actually work :(

Re: Adding Gzip/Gunzip feature in ATS core

I think API is needed. If there is no plugin exists, gzip/unzip is not necessary. I imagine that the one API will guarantee `unzip transform` deal with the body first, another API will guarantee `zip transform` deal with the body last. On Wed, Mar 25, 2015 at 2:37 AM, Leif Hedstrom wrote: > > >

Re: [VOTE] Release v5.2.1

this looks good, i.e.: it fixes the assert. +1 from me. caveat: i had to wipe my cache for it to actually work :( - On 25 Mar, 2015, at 00:45, Leif Hedstrom zw...@apache.org wrote: >> On Mar 23, 2015, at 8:31 PM, Leif Hedstrom wrote: >> >> Hi all, >> >> I've prepared a release candid

Re: [VOTE] Release v5.2.1

> On Mar 23, 2015, at 8:31 PM, Leif Hedstrom wrote: > > Hi all, > > I've prepared a release candidate for v5.2.1, which is a bug-fix over v5.2.0. > The following Jira’s have been addressed in this release: I’ve prepared a new candidate, RC1, which adds the following fix from master: *)

Re: [VOTE] Release v5.2.1

I've back ported to-3140 to 5.2.x, which seems to fix this. > On Mar 24, 2015, at 3:05 PM, Bryan Call wrote: > > I opened: https://issues.apache.org/jira/browse/TS-3464 > > > Alan, > Good find! > > > -Bryan > > >> On Mar 24, 2015, at 1:26

Re: [VOTE] Release v5.2.1

I opened: https://issues.apache.org/jira/browse/TS-3464 Alan, Good find! -Bryan > On Mar 24, 2015, at 1:26 PM, Leif Hedstrom wrote: > > >> On Mar 24, 2015, at 2:14 PM, Bryan Call > > wrote: >> >> I am able to reprodu

Re: Adding Gzip/Gunzip feature in ATS core

> On Mar 24, 2015, at 1:48 PM, Brian Geffon wrote: > > Yes they get called in the order they are registered for better or worse. > Think of it this way, three transformations that all register read request > and read response headers, the first will run first for both and the last > will run las

Re: [VOTE] Release v5.2.1

> On Mar 24, 2015, at 2:14 PM, Bryan Call wrote: > > I am able to reproduce the issue Alan is seeing... > > (gdb) bt full > #0 0x74ef28c7 in raise () from /lib64/libc.so.6 > No symbol table info available. > #1 0x74ef452a in abort () from /lib64/libc.so.6 > No symbol table inf

Re: [VOTE] Release v5.2.1

I am able to reproduce the issue Alan is seeing... (gdb) bt full #0 0x74ef28c7 in raise () from /lib64/libc.so.6 No symbol table info available. #1 0x74ef452a in abort () from /lib64/libc.so.6 No symbol table info available. #2 0x77bb79fb in ink_die_die_die (retval=1) at

RE: Adding Gzip/Gunzip feature in ATS core

That's only true for global hooks - in this case we can extrapolate the ordering, but even there it is tricky. Example, lets say we have three plugins A,B,C and all of them have registered: read request (lets call it req) headers and read respons headers (lets call it resp). In plugin.conf they

Re: Adding Gzip/Gunzip feature in ATS core

Yes they get called in the order they are registered for better or worse. Think of it this way, three transformations that all register read request and read response headers, the first will run first for both and the last will run last for both. This is the fundamental problem. Nonetheless, I thi

Re: [VOTE] Release v5.2.1

- On 24 Mar, 2015, at 16:22, Bryan Call wrote: > +1 - Signatures and regression testing passed on Fedora 21 as far as build goes / test / regression test goes: +1 built on Ubuntu 12.04 and 14.04 (by launchpad ;) > -Bryan >> On Mar 23, 2015, at 7:31 PM, Leif Hedstrom < zw...@apache.org

Re: Adding Gzip/Gunzip feature in ATS core

Hmmm I'm not anywhere near a computer but continuations should get called in the order they were added. Is that not the case ? In the case of global plugins that's the order in the plugin.config. In remap plugins, it's the order in the remap rule. Where it gets iffy is when plugins adds new cont

RE: Adding Gzip/Gunzip feature in ATS core

Setting up unzip plugin at first and zip plugin at last will not help. We tried this already. There is no clear way to control that first response hook will go to unzip plugin and last response hook will go to zip plugin. Also, there might be a case when based on some run-time logic plugins in t

Re: [VOTE] Release v5.2.1

I checked out 5.2.1-rc0, did a clean build and installed fresh. I made the following changes to records.config proxy.config.url.remap.remap_required INT 0proxy.config.http.redirection_enabled INT 1proxy.config.http.number_of_redirections INT 3 If I start this and do "curl --proxy localhost:8080

Re: [VOTE] Release v5.2.1

Well there is nothin in your report to work on, and we are using this exact version on many machines. I honestly have no idea what is going wrong in your system. -- Leif > On Mar 24, 2015, at 11:28 AM, Igor Galić wrote: > > > > - On 24 Mar, 2015, at 12:37, Leif Hedstrom zw...@apache.

Re: [VOTE] Release v5.2.1

- On 24 Mar, 2015, at 12:37, Leif Hedstrom zw...@apache.org wrote: >> On Mar 24, 2015, at 7:20 AM, Igor Galić wrote: >> >> >> >> updated to the rc, and still getting: > > "Still"? Any more details? You sure you don't have some old crud I n the path? probably not, this is a rather clea

Re: [VOTE] Release v5.2.1

+1 - Signatures and regression testing passed on Fedora 21 -Bryan > On Mar 23, 2015, at 7:31 PM, Leif Hedstrom wrote: > > Hi all, > > I've prepared a release candidate for v5.2.1, which is a bug-fix over v5.2.0. > The following Jira’s have been addressed in this release: > > *) [TS-3437]

Re: Adding Gzip/Gunzip feature in ATS core

I got this problem before, I think we can just set the unzip plugin at first and zip plugin at last. On Tue, Mar 24, 2015 at 8:39 PM, Leif Hedstrom wrote: > Makes sense. So it's about knowing if a plugin needs the plain text or > not. I'm not arguing against gzip in the core, we should do that f

RE: Adding Gzip/Gunzip feature in ATS core

I think they can see the updated headers but this doesn't help. A plugin can't know if the next plugin in the chain needs the plain text or even if there is a next plugin. So every plugin is doing the gzip at the end. The next plugin in the chain then will ungzip again. Regards, Roland -Or

Re: Adding Gzip/Gunzip feature in ATS core

Makes sense. So it's about knowing if a plugin needs the plain text or not. I'm not arguing against gzip in the core, we should do that for performance reasons. Not quite sure I see the argument for which plugin does the gzip though, that sounds somewhat of a configuration issue. Something w suc

Re: SSL hook ordering

> On Mar 23, 2015, at 4:15 PM, Susan Hinrichs > wrote: > > I don't have an issue with the re-arrangement. Such a re-arrangement will > require plugins to be recompiled. Is that something we try to avoid until > major releases? Certainly can't break it within a major release. And we sho

Re: Adding Gzip/Gunzip feature in ATS core

I guess I don't understand why the chaining makes a difference. That's what I was asking in the previous email. If two plugins are chained, one should be able to detect gzip or not gzip the same way it does as if it was not chained. What am I missing ? Does each chained plugin not see the update

Re: [VOTE] Release v5.2.1

> On Mar 24, 2015, at 7:20 AM, Igor Galić wrote: > > > > updated to the rc, and still getting: "Still"? Any more details? You sure you don't have some old crud I n the path? -- Leif > > ==> /var/log/trafficserver/manager.log <== > [Mar 24 11:16:49.395] Manager {0x7f7530f28780} ERROR:

Re: [VOTE] Release v5.2.1

updated to the rc, and still getting: ==> /var/log/trafficserver/manager.log <== [Mar 24 11:16:49.395] Manager {0x7f7530f28780} ERROR: [LocalManager::pollMgmtProcessServer] Server Process terminated due to Sig 11: Segmentation fault [Mar 24 11:16:49.395] Manager {0x7f7530f28780} ERROR: [Alarms