Questions on bnull_transform logic

2015-03-17 Thread Brian Rectanus
Hi, Continuing my investigation of some unexplained latency issues, I am going back through the bnull_transform logic to check our logic. With this I have a few questions: In bnull_transform.c the logic is that a state variable determines if we are buffering or writing. Data is read and buffered

[GitHub] trafficserver pull request: TS-3447 [buffer_upload plugin] set Url...

2015-03-17 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/181#discussion_r26591169 --- Diff: plugins/experimental/buffer_upload/buffer_upload.cc --- @@ -753,6 +753,15 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */, TSEvent event

[GitHub] trafficserver pull request: TS-3447 [buffer_upload plugin] set Url...

2015-03-17 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/181#discussion_r26590946 --- Diff: plugins/experimental/buffer_upload/buffer_upload.cc --- @@ -753,6 +753,15 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */, TSEvent event

[GitHub] trafficserver pull request: TS-3447 [buffer_upload plugin] set Url...

2015-03-17 Thread yzlai
Github user yzlai commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/181#discussion_r26576225 --- Diff: plugins/experimental/buffer_upload/buffer_upload.cc --- @@ -753,6 +753,15 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */, TSEvent event, vo

[GitHub] trafficserver pull request: TS-3447 [buffer_upload plugin] set Url...

2015-03-17 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/181#discussion_r26573216 --- Diff: plugins/experimental/buffer_upload/buffer_upload.cc --- @@ -753,6 +753,15 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */, TSEvent

[GitHub] trafficserver pull request: TS-3447 [buffer_upload plugin] set Url...

2015-03-17 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/181#discussion_r26573116 --- Diff: plugins/experimental/buffer_upload/buffer_upload.cc --- @@ -753,6 +753,15 @@ attach_pvc_plugin(TSCont /* contp ATS_UNUSED */, TSEvent