Re: clang-format on "master"

2015-02-28 Thread Leif Hedstrom
> On Feb 28, 2015, at 9:35 PM, Phil Sorber wrote: > > On Wed Feb 25 2015 at 9:15:38 AM James Peach wrote: > >> >>> On Feb 24, 2015, at 1:59 PM, Leif Hedstrom wrote: >>> >>> Hi, >>> >>> clang-format has finally gotten to the point where we can get it to >> format our code similar, but not q

Re: clang-format on "master"

2015-02-28 Thread Leif Hedstrom
> On Feb 24, 2015, at 2:59 PM, Leif Hedstrom wrote: > > Hi, > > clang-format has finally gotten to the point where we can get it to format > our code similar, but not quite identical, to what we have today. Doing all > formatting programmatically has several benefits: > > It’s no longer up t

Re: clang-format on "master"

2015-02-28 Thread Phil Sorber
On Wed Feb 25 2015 at 9:15:38 AM James Peach wrote: > > > On Feb 24, 2015, at 1:59 PM, Leif Hedstrom wrote: > > > > Hi, > > > > clang-format has finally gotten to the point where we can get it to > format our code similar, but not quite identical, to what we have today. > Doing all formatting pr

[GitHub] trafficserver pull request: [TS-3396] new tsqa_spdy protocol selec...

2015-02-28 Thread ericcarlschwartz
Github user ericcarlschwartz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/172#discussion_r25563097 --- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py --- @@ -0,0 +1,141 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] trafficserver pull request: [TS-3396] new tsqa_spdy protocol selec...

2015-02-28 Thread jacksontj
Github user jacksontj commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/172#discussion_r25561984 --- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py --- @@ -0,0 +1,141 @@ +# Licensed to the Apache Software Foundation (ASF) under one