[REVIEW REQUEST] ClassAllocator Improvements

2014-11-06 Thread Brian Geffon
All, Cynthia Gu has put together a great patch that improves the ClassAllocators. Firstly she added a configurable low watermark for ClassAllocators that prevent it from returning all its items whenever it exceeds the configurable limit. Additionally, in the current implementation it returns items

Re: [API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-06 Thread Brian Geffon
Alan, Take a look at the final commit, we're on the same page. Brian On Thu, Nov 6, 2014 at 1:38 PM, Alan M. Carroll wrote: > We are simply incapable of doing anything in a simple way. > > I see James' point but I disagree with his implementation. > > I would recommend setting the refcount to 1

Re: [API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-06 Thread Alan M. Carroll
We are simply incapable of doing anything in a simple way. I see James' point but I disagree with his implementation. I would recommend setting the refcount to 1 on allocate and doing just > if (mutextp->refcount_dec() == 0) { > mutextp->free(); >