Re: [API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-05 Thread Leif Hedstrom
> On Nov 4, 2014, at 6:20 PM, Brian Geffon wrote: > > This should be self explanatory and IMO we should land for 5.2, the > following patch is also attached to TS-1432. I obviously haven’t tested it, but seems straightforward and useful. +1 — leif

Re: libck and C++

2014-11-05 Thread Phil Sorber
Adding Wez On Wed, Nov 5, 2014 at 12:30 PM, Phil Sorber wrote: > 12:18 < sbahra> how about you kick off an e-mail to me and we discuss over > e-mail? > 12:18 < sbahra> Well, the real limitation is that testing overhead is high. > 12:19 < sbahra> I was thinking, if we invest some time to automate

libck and C++

2014-11-05 Thread Phil Sorber
12:18 < sbahra> how about you kick off an e-mail to me and we discuss over e-mail? 12:18 < sbahra> Well, the real limitation is that testing overhead is high. 12:19 < sbahra> I was thinking, if we invest some time to automate a lot of the testing then it would be feasible. 12:20 < sbahra> Right now

Re: [API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-05 Thread James Peach
> On Nov 4, 2014, at 4:20 PM, Brian Geffon wrote: > > This should be self explanatory and IMO we should land for 5.2, the > following patch is also attached to TS-1432. +1 on the API For the implementation, I think you should take reference counting into account. Maybe something along these l