[API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-04 Thread Brian Geffon
This should be self explanatory and IMO we should land for 5.2, the following patch is also attached to TS-1432. Brian diff --git a/proxy/InkIOCoreAPI.cc b/proxy/InkIOCoreAPI.cc index 26f3298..091d7a2 100644 --- a/proxy/InkIOCoreAPI.cc +++ b/proxy/InkIOCoreAPI.cc @@ -189,6 +189,11 @@ TSMutexCre

Re: ATS Integration Testing

2014-11-04 Thread Cynthia Gu
Brian, Just some thoughts on collaboration. Most of the contributors are local is definite something advantage we can take. Since it’s a framework, we probably need some initial meetings/phone calls to come up with a robust easy-to-use framework. After that, we can start to implement test cases in

Re: git commit: Add support for Content-Length in background_fetch config

2014-11-04 Thread Sudheer Vinukonda
Hi Alan, Sure - but, unfortunately, it looks like there¹s something wrong with the automatic propagation of the commit SHA onto the jira for the past few days. It¹s not been updating the commit SHA on the jira, despite mentioning the jira ticket # in the commit message. Thanks, Sudheer On 11/4

Re: git commit: Add support for Content-Length in background_fetch config

2014-11-04 Thread Alan M. Carroll
Monday, November 3, 2014, 2:57:00 PM, you wrote: > This change is part of TS-2683 - I will try to update the CHANGES file > with a consolidated list of changes made for TS-2683. Will that work? If you could, also put the commit SHA in a comment on the ticket. That's very useful later on. This ha

Re: ATS Integration Testing

2014-11-04 Thread நாராயண்
Brian, Agree with Josh. You have captured the requirements well. AFAICT, most of the contributors are local - LinkedIn, Apple and Yahoo. Phone call, irc is all good. We can even meet to nail this. Thanks, Narayan On Tue, Nov 4, 2014 at 10:01 AM, Brian Geffon wrote: > Hi All, thanks for your

Re: ATS Integration Testing

2014-11-04 Thread Joshua Blatt
Hi Brian, This is a nice overview.  I think you've captured the requirements nicely.   The only change I'd suggest is that it'd be nice to turn the functional test framework into a lightweight load test because some issues will only be seen under load.   This wouldn't be able to hammer ATS

ATS Integration Testing

2014-11-04 Thread Brian Geffon
Hi All, thanks for your patience I know many people are eager to start pooling resources to make this happen. (Thanks Susan for helping with notes during the summit) To briefly summarize what was discussed at the summit, we have an existing framework called TSQA which is based on bash, while this

Re: Working on functional test framework

2014-11-04 Thread Brian Geffon
Sorry guys I've been traveling and haven't had the chance to start the discussions on this. We more or less have our requirements as gathered at the summit I'll try to send them out today so we can begin discussing a roadmap. Brian On Monday, November 3, 2014, Joshua Blatt wrote: > Good feedbac