[GitHub] trafficserver pull request: Explain ATS's interesting default SSL ...

2014-09-24 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/121#issuecomment-56779468 But what happens if there are 2 found for the same IP address? Which one is the fallback? That's all I'm trying to document is that there is an order in wh

[GitHub] trafficserver pull request: Explain ATS's interesting default SSL ...

2014-09-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/121#issuecomment-56770923 Each certificate is indexed by the subject CN, all the alternate names and the IP address given in ssl_multicert. When we try to match the client connection, we mat

[GitHub] trafficserver pull request: Explain ATS's interesting default SSL ...

2014-09-24 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/121#issuecomment-56770441 Well, this is how it works regardless of how it should work... But you should be able to specify multiple certs for a given IP (for example) so sni cl

[GitHub] trafficserver pull request: Explain ATS's interesting default SSL ...

2014-09-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/121#issuecomment-56768823 That's not how it works. In all cases, we should be taking the longest match. If multiple certificates have the same matching specifier we should be issuing a warni

[GitHub] trafficserver pull request: Explain ATS's interesting default SSL ...

2014-09-24 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/121 Explain ATS's interesting default SSL cert selection criteria You can merge this pull request into a Git repository by running: $ git pull https://github.com/jacksontj/trafficserver m

Re: git commit: Build error fixes (Bison/Flex version check, ssl_cert_loader)

2014-09-24 Thread James Peach
On Sep 24, 2014, at 1:56 PM, a...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master 60e8d9764 -> 676482c58 > > > Build error fixes (Bison/Flex version check, ssl_cert_loader) oarfish:trafficserver.git jpeach$ ./configure ... configure: error: Need bison vers

Re: TS-2314 review comments

2014-09-24 Thread James Peach
On Sep 24, 2014, at 10:03 AM, James Peach wrote: > Hi Sudheer, > > I reviewed TS-2314 and had a few comments ... > > The records.config.en.rst documentation is not as clear as it could be. From > our IRC discussion, it seems like the values should be: > > 0 - never read while writing >

TS-2314 review comments

2014-09-24 Thread James Peach
Hi Sudheer, I reviewed TS-2314 and had a few comments ... The records.config.en.rst documentation is not as clear as it could be. From our IRC discussion, it seems like the values should be: 0 - never read while writing 1 - always read while writing 2 - always read while

[GitHub] trafficserver pull request: Ts 3006 fix regression

2014-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Ts 3006 fix regression

2014-09-24 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/120 Ts 3006 fix regression Fix RHEL5 build errors. Fix a documentation typo. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shinrich/tra

Re: Minimum OpenSSL version

2014-09-24 Thread James Peach
On Sep 24, 2014, at 8:40 AM, Susan Hinrichs wrote: > Noticed something in the RHEL5 build while tracking down build errors. For > RHEL5 master build TS_USE_TLS_SNI is not defined which means the function > SSL_CTX_set_tlsext_servername_callback is not set in the version of openssl > used by

Re: Minimum OpenSSL version

2014-09-24 Thread Susan Hinrichs
The function SSL_set_SSL_CTX is missing in openssl 0.9.7 and also not accessible in the RHEL5 builds. On 9/24/2014 10:40 AM, Susan Hinrichs wrote: Noticed something in the RHEL5 build while tracking down build errors. For RHEL5 master build TS_USE_TLS_SNI is not defined which means the funct

Re: git commit: [TS-3085] Large POSTs over (relatively) slower connections failing in ats5 Call ERR_get_error_line_data() via SSL_CLR_ERR_INCR_DYN_STAT to clean up the error queue after processing an

2014-09-24 Thread James Peach
On Sep 24, 2014, at 6:40 AM, sudhe...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master 17bef772a -> d12327d84 > > > [TS-3085] Large POSTs over (relatively) slower connections failing in ats5 > Call ERR_get_error_line_data() via SSL_CLR_ERR_INCR_DYN_STAT to c

Re: Minimum OpenSSL version

2014-09-24 Thread Susan Hinrichs
Noticed something in the RHEL5 build while tracking down build errors. For RHEL5 master build TS_USE_TLS_SNI is not defined which means the function SSL_CTX_set_tlsext_servername_callback is not set in the version of openssl used by RHEL5. This means that SSL certificate support in 5.x will

[GitHub] trafficserver pull request: Added Unique Identifier to HttpSM, to ...

2014-09-24 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/106#issuecomment-56677407 Yes, putting in the Machine instance sounds good. But it must be non-persistent across process restarts, because the SM id isn't. The goal is to have a UU

[GitHub] trafficserver pull request: TS-3006 fix regression again. Must pro...

2014-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3006 fix regression again. Must pro...

2014-09-24 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/119 TS-3006 fix regression again. Must propagate constants into test Added elements to the parallel test HOOK enum to satisfy regression test. You can merge this pull request into a Git reposit