Re: [API REVIEW] TSHttpHdrHostGet

2014-09-19 Thread James Peach
On Sep 19, 2014, at 3:09 PM, Alan M. Carroll wrote: > TSHttpHdrHostGet > == > > Synopsis > > > `#include ` > > .. c:function:: const char* TSHttpHdrHostGet(TSMBuffer bufp, TSMLoc offset, > int *length) > > > Description > --- > > Get the host for the reque

[API REVIEW] TSHttpHdrHostGet

2014-09-19 Thread Alan M. Carroll
TSHttpHdrHostGet == Synopsis `#include ` .. c:function:: const char* TSHttpHdrHostGet(TSMBuffer bufp, TSMLoc offset, int *length) Description --- Get the host for the request. :arg:`bufp` and :arg:`offset` must reference an HTTP request header. A pointer to

[GitHub] trafficserver pull request: TS-3059 Add missing TSTextLogObjectRol...

2014-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [API REVIEW FOLLOWUP] Adding missing TSTextLogObjectRollingSizeMbSet() function

2014-09-19 Thread James Peach
On Sep 19, 2014, at 10:33 AM, Brian Rectanus wrote: > This is a followup on the API review I posted earlier. I got quite a bit > of feedback (thanks for that) and want to summarize and verify I understood > comments correctly. I don't think there were any -1s for the existing pull > request, but

[API REVIEW FOLLOWUP] Adding missing TSTextLogObjectRollingSizeMbSet() function

2014-09-19 Thread Brian Rectanus
This is a followup on the API review I posted earlier. I got quite a bit of feedback (thanks for that) and want to summarize and verify I understood comments correctly. I don't think there were any -1s for the existing pull request, but just some recommendations on how this could be improved. Thi

5.1.x

2014-09-19 Thread Alan M. Carroll
Now that 5.1.0 is released, you can request backports from master to 5.1.x for 5.1.1. Such requests should be for serious, "must have" fixes for the community. As usual, no JIRA ticket, no backport. The fix must already exist, be committed to master, and tested. To be clear, no fixes will be dir

Re: [1/2] git commit: TS-2802: Additional fixups. Changed NetVCOptions to use ats_scoped_str instead of a raw pointer. Added comments.

2014-09-19 Thread James Peach
On Sep 19, 2014, at 8:38 AM, Alan M. Carroll wrote: > Friday, September 19, 2014, 10:12:29 AM, you wrote: > > >>> + sni_servername.release(); // otherwise we'll free the source string. > > >> Why don't you want to free the source string in this case? > > Because it's still in the sourc

Re: [1/2] git commit: TS-2802: Additional fixups. Changed NetVCOptions to use ats_scoped_str instead of a raw pointer. Added comments.

2014-09-19 Thread Alan M. Carroll
Friday, September 19, 2014, 10:12:29 AM, you wrote: >> + sni_servername.release(); // otherwise we'll free the source string. > Why don't you want to free the source string in this case? Because it's still in the source object and therefore it would be freed again at some point in the fut

Re: [1/2] git commit: TS-2802: Additional fixups. Changed NetVCOptions to use ats_scoped_str instead of a raw pointer. Added comments.

2014-09-19 Thread James Peach
On Sep 19, 2014, at 6:30 AM, a...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master a9905459d -> 4a143e584 > > > TS-2802: Additional fixups. > Changed NetVCOptions to use ats_scoped_str instead of a raw pointer. > Added comments. > > > Proj