Re: [API REVIEW] TSHttpIsInternalSession

2014-05-28 Thread Brian Geffon
Makes sense +1. Brian On Wed, May 28, 2014 at 9:12 PM, James Peach wrote: > Hi all, > > I'd like to add a session-oriented counterpart to TSHttpIsInternalRequest, > named TSHttpIsInternalSession: > > TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp); > > This API has identical seman

[API REVIEW] TSHttpIsInternalSession

2014-05-28 Thread James Peach
Hi all, I'd like to add a session-oriented counterpart to TSHttpIsInternalRequest, named TSHttpIsInternalSession: TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp); This API has identical semantics to TSHttpIsInternalRequest, except that it operates on a TSHttpSsn instead of a TSHtt

Re: git commit: TS-2856: Remove proxy.config.spdy.verbose_in and use diags instead

2014-05-28 Thread James Peach
Nice! On May 28, 2014, at 5:46 PM, bc...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master d22f98910 -> d0f4d5c47 > > > TS-2856: Remove proxy.config.spdy.verbose_in and use diags instead > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/r

Re: 5.0.0 bugs / stability

2014-05-28 Thread Bryan Call
The current plan is to create the 5.0 release on Friday (May 30th) and I will put up the vote for 7 days. We had 180+ tickets for 5.0 last Monday and we are down to 30 today. There has been a lot of great work done on this release. We have been running 5.0 (master) since late April with SPDY s

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-28 Thread Bryan Call
On May 26, 2014, at 6:00 PM, James Peach wrote: > Bryan, > > How are you expecting proxy.process.ssl.total_handshake_time to be used? What > units is it in? Unless I'm missing something, the aggregate handshake time > does not seem very interesting. We wanted to get a better picture of the S

Re: git commit: TS-2838 Add log fields for plugins on HttpSM and use for SPDY.

2014-05-28 Thread James Peach
Please remove the documentation for the 'cps' log field. Please document the 'piid' log field. I don't see how this is wired up to SPDY, could you spell that out for me? On May 23, 2014, at 9:30 AM, a...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master b63839