Re: git commit: TS-2830 Make SPDY configurable.

2014-05-21 Thread James Peach
On May 21, 2014, at 6:24 PM, a...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master 24d860c05 -> b7e69b0fa > > > TS-2830 Make SPDY configurable. [snip] > cts only new SPDY connections, not existing connects. > + > +.. ts:cv:: CONFIG proxy.config.spdy.verbose_

Re: git commit: TS-2830 Make gcc 4.1.2 happy.

2014-05-21 Thread James Peach
On May 21, 2014, at 6:58 PM, a...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master ad6d30052 -> ada6b33e8 > > > TS-2830 Make gcc 4.1.2 happy. > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > Commit: http://git-wip-us.apache.org/rep

Re: [RFC] coding style for member variable access

2014-05-21 Thread John Plevyak
I'm with Brian. You need to do this some time with templates and it seems busy to me. However there are probably exceptions... On May 21, 2014 2:31 PM, "Brian Geffon" wrote: > I think this-> is incredibly ugly an unnecessary, what does it really get > us? It will be become convention just as ap

Re: [GitHub] trafficserver pull request: docs: Add Doxygen group commands to AP...

2014-05-21 Thread James Peach
On May 17, 2014, at 7:57 PM, Jack Bates <6ny...@nottheoilrig.com> wrote: > Good point, > I'll look into whether those strings can be translated somehow. I looked at this patch more today, and while I think it's a nice piece of work, I question whether we should be splitting our API documentation

Re: [RFC] coding style for member variable access

2014-05-21 Thread Brian Geffon
I think this-> is incredibly ugly an unnecessary, what does it really get us? It will be become convention just as appending a underscore or adding m_ in front of the name. In my opinion this-> should only be used in situations where you need to disambiguate between variable names and not as a conv

[GitHub] trafficserver pull request: docs: Minor edits

2014-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: docs: Minor edits

2014-05-21 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/88 docs: Minor edits You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver minor_edits Alternatively you can review and apply

[RFC] coding style for member variable access

2014-05-21 Thread James Peach
Hi all, Leif pointed out that I've been doing this, and now I'd like to propose this as an official style guideline. Within a class member function, access to class members should use the explicit "this->foo" syntax. The rationale for this is that it makes it blindingly obvious that cl

[GitHub] trafficserver pull request: Set the rpath when built "--with-opens...

2014-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: fix for TS-2779 (atscppapi: bug in Asy...

2014-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [1/2] git commit: [TS-2822] Crash in LogBufferIterator::next

2014-05-21 Thread James Peach
On May 21, 2014, at 9:50 AM, bri...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master 2ba2baaa6 -> 374355c01 > > > [TS-2822] Crash in LogBufferIterator::next > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > Commit: http://git-wip-u

Re: git commit: TS-2555: add more hook support for ts_lua plugin

2014-05-21 Thread Shu Kit Chan
I agree that global functions for hooks is ugly. I can add similar thing as the lua plugin and allow registering hooks outside of global functions before 5.0.0 release. Quehan also has a patch with the idea of using the return value of the registered function of hooks to control the reenabling of

Re: git commit: TS-2555: add more hook support for ts_lua plugin

2014-05-21 Thread James Peach
On May 20, 2014, at 9:59 PM, kic...@apache.org wrote: > Repository: trafficserver > Updated Branches: > refs/heads/master 90f44b522 -> 2ba2baaa6 > > > TS-2555: add more hook support for ts_lua plugin I still think that declaring global functions for hooks is ugly and not Lua-like. Automatical

[GitHub] trafficserver pull request: Fix the automake rule to satisfy heade...

2014-05-21 Thread syucream
Github user syucream commented on the pull request: https://github.com/apache/trafficserver/pull/80#issuecomment-43770175 Thank you for your review. I agree with your opinion and want to continue discussion to solve it on JIRA. so I close this pull-request for now. --- If your projec

[GitHub] trafficserver pull request: Fix the automake rule to satisfy heade...

2014-05-21 Thread syucream
Github user syucream closed the pull request at: https://github.com/apache/trafficserver/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature