Re: [DISCUSS} Changes to TSHttpTxnErrorBodySet and TSHttpTxnSetHttpRetBody

2014-03-25 Thread Nick Kew
On Tue, 2014-03-25 at 20:25 -0600, Phil Sorber wrote: > > > An API change like that affects existing plugins and could leave us > > > needing some ugly #ifdef crap to support both before- and after- TS > > > versions. Can I make a plea to avoid that: maybe a new function name, > > > and migrate t

Re: Remap/regex_remap consolidation

2014-03-25 Thread Thomas Jackson
Another consideration for having >1 regex (which may or may not be premature optimization) is that if you have seperate regexes we can create hash maps similar to how maps work (a hashmap of domain_regex -> list of path regexes) which would make overall remap performance faster/better. On Tue, Ma

Re: Remap/regex_remap consolidation

2014-03-25 Thread Brian Geffon
Right. On Tuesday, March 25, 2014, Leif Hedstrom wrote: > > On Mar 25, 2014, at 7:51 PM, Brian Geffon > > > wrote: > > > What Thomas called Question #1 -- 1 Regex. > > > > Makes sense to have them combined. Assuming groups etc. works, that allows > you to do e.g. > >regex_map http://(.*)\.o

Re: [DISCUSS} Changes to TSHttpTxnErrorBodySet and TSHttpTxnSetHttpRetBody

2014-03-25 Thread Phil Sorber
On Tue, Mar 25, 2014 at 8:39 AM, Leif Hedstrom wrote: > > On Mar 25, 2014, at 12:16 AM, Nick Kew wrote: > > > On Mon, 2014-03-24 at 20:39 -0600, Leif Hedstrom wrote: > > > >> with a consistent transfer of ownership of both "body" and > "content_type", both will be free()'d when the core no longe

Re: Remap/regex_remap consolidation

2014-03-25 Thread Leif Hedstrom
On Mar 25, 2014, at 7:51 PM, Brian Geffon wrote: > What Thomas called Question #1 -- 1 Regex. > Makes sense to have them combined. Assuming groups etc. works, that allows you to do e.g. regex_map http://(.*)\.ogre\.com/([^/]+)/(.*) http://$2/$1/$3 or some such. i.e. take parts from the

Re: Remap/regex_remap consolidation

2014-03-25 Thread Brian Geffon
What Thomas called Question #1 -- 1 Regex. Brian On Tuesday, March 25, 2014, Leif Hedstrom wrote: > > On Mar 25, 2014, at 7:42 PM, Brian Geffon > > wrote: > > > I personally vote for regexing everything until we get around to > finalizing > > lua config, I also vote for this being the one who w

Re: Remap/regex_remap consolidation

2014-03-25 Thread Leif Hedstrom
On Mar 25, 2014, at 7:42 PM, Brian Geffon wrote: > I personally vote for regexing everything until we get around to finalizing > lua config, I also vote for this being the one who will end up writing the > code :) Which option is that? — Leif

Re: Remap/regex_remap consolidation

2014-03-25 Thread Brian Geffon
I personally vote for regexing everything until we get around to finalizing lua config, I also vote for this being the one who will end up writing the code :) Brian On Tuesday, March 25, 2014, James Peach wrote: > On Mar 25, 2014, at 3:28 PM, Leif Hedstrom > > wrote: > > > > > On Mar 25, 2014,

Re: Remap/regex_remap consolidation

2014-03-25 Thread James Peach
On Mar 25, 2014, at 3:28 PM, Leif Hedstrom wrote: > > On Mar 25, 2014, at 4:08 PM, James Peach wrote: > >> On Mar 25, 2014, at 1:50 PM, Thomas Jackson wrote: >> >>> Here at LinkedIn we've been using regular remap.config for a while (with >>> all our map options). One thing we've been looking

Re: Remap/regex_remap consolidation

2014-03-25 Thread Leif Hedstrom
On Mar 25, 2014, at 4:08 PM, James Peach wrote: > On Mar 25, 2014, at 1:50 PM, Thomas Jackson wrote: > >> Here at LinkedIn we've been using regular remap.config for a while (with >> all our map options). One thing we've been looking into recently is path >> based regexes (which regex_remap sup

Re: Remap/regex_remap consolidation

2014-03-25 Thread James Peach
On Mar 25, 2014, at 1:50 PM, Thomas Jackson wrote: > Here at LinkedIn we've been using regular remap.config for a while (with > all our map options). One thing we've been looking into recently is path > based regexes (which regex_remap supports). While looking into it we found > a few shortcoming

Remap/regex_remap consolidation

2014-03-25 Thread Thomas Jackson
Here at LinkedIn we've been using regular remap.config for a while (with all our map options). One thing we've been looking into recently is path based regexes (which regex_remap supports). While looking into it we found a few shortcomings of the plugin-- and decided it would probably be better for

Re: TCP Fast Open (TFO) in Traffic Server

2014-03-25 Thread Ben
On Wed, Jan 22, 2014 at 10:18:45AM -0200, Alex Garz?o wrote: > Hello, > > Ticket: https://issues.apache.org/jira/browse/TS-2520. > > I am a newbie in ATS, but I would like to contribute. Can I implement > a patch to solve this? Did this ever go anywhere? I'm still interested in such, but as far

[GitHub] trafficserver pull request: Change default to keep_alive_post_out

2014-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: Remaporder

2014-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [DISCUSS} Changes to TSHttpTxnErrorBodySet and TSHttpTxnSetHttpRetBody

2014-03-25 Thread Leif Hedstrom
On Mar 25, 2014, at 12:16 AM, Nick Kew wrote: > On Mon, 2014-03-24 at 20:39 -0600, Leif Hedstrom wrote: > >> with a consistent transfer of ownership of both “body” and “content_type”, >> both will be free()’d when the core no longer needs them. > > ISTR that being a minor "gotcha". There's a