Re: [DISCUSS} Changes to TSHttpTxnErrorBodySet and TSHttpTxnSetHttpRetBody

2014-03-24 Thread Nick Kew
On Mon, 2014-03-24 at 20:39 -0600, Leif Hedstrom wrote: > with a consistent transfer of ownership of both “body” and “content_type”, > both will be free()’d when the core no longer needs them. ISTR that being a minor "gotcha". There's a comment in the Ironbee code about the body being freed so

Re: [DISCUSS} Changes to TSHttpTxnErrorBodySet and TSHttpTxnSetHttpRetBody

2014-03-24 Thread Leif Hedstrom
On Mar 24, 2014, at 3:26 PM, James Peach wrote: > On Mar 24, 2014, at 9:45 AM, Leif Hedstrom wrote: > >> 3. In order to make the TSHttpTxnErrorBodySet() API easier to use, I’ve >> changed the content type argument to not transfer ownership. The common >> (well, exclusive) pattern using this

[GitHub] trafficserver pull request: Remaporder

2014-03-24 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/67 Remaporder Clear up some of the ordering questions (how they work) and clear out some trailing whitespace You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] trafficserver pull request: Change default to keep_alive_post_out

2014-03-24 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/66#issuecomment-38512802 keep_alive_post_out, can't really think of a scenario where you'd *actually* want keepalive for non-POST and non-keepalive for POSTs. --- If your project is set

[GitHub] trafficserver pull request: Change default to keep_alive_post_out

2014-03-24 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/66 Change default to keep_alive_post_out Keepalive post out used to cause issues, but we have since found and fixed the root cause (TS-2497) and we are now running this on in production. This

Re: [DISCUSS} Changes to TSHttpTxnErrorBodySet and TSHttpTxnSetHttpRetBody

2014-03-24 Thread James Peach
On Mar 24, 2014, at 9:45 AM, Leif Hedstrom wrote: > Hi all, > > > We currently have two APIs to set an “error” body. One was added at Yahoo > many years ago, and it was done for the wrong reasons (premature optimization > being one of them). I’ve made a patch that unifies these two APIs into

[DISCUSS} Changes to TSHttpTxnErrorBodySet and TSHttpTxnSetHttpRetBody

2014-03-24 Thread Leif Hedstrom
Hi all, We currently have two APIs to set an “error” body. One was added at Yahoo many years ago, and it was done for the wrong reasons (premature optimization being one of them). I’ve made a patch that unifies these two APIs into one, such that you can use TSHttpTxnErrorBodySet() anywhere you