Re: SDK and string "copies"

2010-12-02 Thread Leif Hedstrom
On 12/02/2010 08:05 PM, Jason wrote: ditto +1, just have to make a point of it in the docs Absolutely, I will file separate bug(s) for that (doing this change will definitely eliminate the requirement for ever having to call TSHandleStringRelease(), which actually simplifies the usage of the

Re: SDK and string "copies"

2010-12-02 Thread Alan M. Carroll
+1 Thursday, December 2, 2010, 6:47:11 PM, you wrote: > I think it'd make much more sense to consistently make all APIs that > deals with strings like this not be NULL terminated. This would require > no API changes, just that the "semantics" would change. And I think the > requirement to 'rel

Re: SDK and string "copies"

2010-12-02 Thread Jason
ditto +1, just have to make a point of it in the docs On Dec 2, 2010, at 9:23 PM, Eric Balsa wrote: > I'm +1 for making stuff non-null and returning a pointer straight into > the MBuf like you propose. > > The only problem I see is that plugin writers will get direct access > to the MBuf and on

Re: SDK and string "copies"

2010-12-02 Thread Eric Balsa
I'm +1 for making stuff non-null and returning a pointer straight into the MBuf like you propose. The only problem I see is that plugin writers will get direct access to the MBuf and one could cast and change data directly (but these are getters!). Before, you were operating on a copy of that data

Re: SDK and string "copies"

2010-12-02 Thread Manish Pandey
Seems like an great idea for simplifying memory management. The overhead of dealing with non-NULL termination should be minor. Isn't there an equivalent of TSHttpBodyGet(TSMBuffer bufp, TSMLoc obj, int *length); Manish On Thu, Dec 2, 2010 at 4:47 PM, Leif Hedstrom wrote: > Hi, > > here's an id

SDK and string "copies"

2010-12-02 Thread Leif Hedstrom
Hi, here's an idea, that could optimize memory allocation pressure significantly (I think) when writing plugins. Here's the deal; A few plugin APIs will make copies of the strings from the internal marshal buffers, before returning them, with the only purpose of making them NULL terminated. T

Re: Printing origin server response / How to inspect body?

2010-12-02 Thread Manish Pandey
I have looked at the examples in the SDK doc, and couldn't see any example of proxy operation that depends on the content of the body - Any suggestions on how to obtain the string to inspect the body? What I have tried does not seem to work ... and will appreciate any help. Seems like I am missing