Re: [PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]

2025-01-24 Thread via GitHub
tballison merged PR #2085: URL: https://github.com/apache/tika/pull/2085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org

Re: [PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]

2025-01-24 Thread via GitHub
tballison commented on PR #2085: URL: https://github.com/apache/tika/pull/2085#issuecomment-2612396962 I'll merge this as soon as the checks pass. On a follow-on PR, if you have a chance, would you be able to create/find an ASL 2.0-compatible test file for a unit test? -- This is an auto

Re: [PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]

2025-01-24 Thread via GitHub
subbudvk commented on PR #2085: URL: https://github.com/apache/tika/pull/2085#issuecomment-2612380253 @tballison you are right. The Jar detector decides content based on the presence of MANIFEST.MF. The android package bundle will also have MANIFEST.MF, so to guarantee the order and JarDet

Re: [PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]

2025-01-24 Thread via GitHub
tballison commented on PR #2085: URL: https://github.com/apache/tika/pull/2085#issuecomment-2612368867 I'm sorry for my delay on this. Is there a reason to put the android logic in the jar detector instead of a separate detector? The good thing about the current PR is that it guarantees the

[PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]

2025-01-03 Thread via GitHub
subbudvk opened a new pull request, #2085: URL: https://github.com/apache/tika/pull/2085 Thanks for your contribution to [Apache Tika](https://tika.apache.org/)! Your help is appreciated! Before opening the pull request, please verify that * there is an open issue on the [T