[dev] Re: [st] Bugs in scrollback buffer patch

2015-03-19 Thread Christian Neukirchen
Alex Pilon writes: > On Sat, Mar 14, 2015 at 01:08:14PM +0100, Roberto E. Vargas Caballero wrote: >> > * You can scroll past the top line in the buffer. Fixed with the >> > attached diff. >> >> You can push your changes to the wiki if you want. > > I will, and again when I fix those two other i

Re: [dev] Re: [st] Bugs in scrollback buffer patch

2015-03-19 Thread Alex Pilon
On Thu, Mar 19, 2015 at 11:12:16AM +0100, Christian Neukirchen wrote: > There is still a bug that corrupts the last line when you are scrolled > up and output happens simultaneously. Yeah. I know. I only pushed because I won't be able to fix it for at least a week. > (I'm not familar with the cod

[dev] [PATCH quark] Fix chroot argument

2015-03-19 Thread Alexander Huemer
--- quark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quark.c b/quark.c index 9c8928d..ff13592 100644 --- a/quark.c +++ b/quark.c @@ -710,7 +710,7 @@ main(int argc, char *argv[]) logerrmsg("error\tchdir %s: %s\n", chrootdir, strerror(errno));

Re: [dev] [PATCH quark] Fix chroot argument

2015-03-19 Thread Connor Lane Smith
On 19 March 2015 at 22:25, Alexander Huemer wrote: > - if (chroot(".") == -1) { > + if (chroot(chrootdir) == -1) { This looks wrong; see line 709: > if (chdir(chrootdir) == -1) { So on line 713 . should be chrootdir, because it just chdir'd there. cls

Re: [dev] [PATCH quark] Fix chroot argument

2015-03-19 Thread Alexander Huemer
On Thu, Mar 19, 2015 at 10:52:36PM +, Connor Lane Smith wrote: > On 19 March 2015 at 22:25, Alexander Huemer wrote: > > - if (chroot(".") == -1) { > > + if (chroot(chrootdir) == -1) { > > This looks wrong; see line 709: > > > if (chdir(chrootdir) == -1) { > > So on line 713 . sh

Re: [dev] [st] segfault when selecting text

2015-03-19 Thread Henrique Lengler
On Wed, Mar 18, 2015 at 02:57:03PM -0300, Henrique Lengler wrote: > On Wed, Mar 18, 2015 at 07:02:28AM +0100, Roberto E. Vargas Caballero wrote: > > Your problem is the commit 72d2accc22 which removed _BSD_SOURCE > > and introduced _DEFAULT_SOURCE instead, but since strsep is not a > > POSIX functi