Re: [dev] [PATCH] Simplify README

2014-08-18 Thread Roberto E. Vargas Caballero
> The term 'virtual terminal emulator' was broken. There is nothing > virtual about it, it's a terminal emulator. Yeah, it was a bad sentence. Usually the term 'virtual terminal' is used for the terminal emulator built in linux kernel, but it is a non sense here. Thanks, -- Roberto E. Vargas C

Re: [dev] [PATCH] Simplify README

2014-08-18 Thread Claudio
AFAIK a terminal is an hardware device. Since st is only a software implementation it's ok to call it a virtual terminal emulator, isn't? 2014-08-18 12:13 GMT+02:00 Roberto E. Vargas Caballero : >> The term 'virtual terminal emulator' was broken. There is nothing >> virtual about it, it's a termi

Re: [dev] [PATCH] Simplify README

2014-08-18 Thread Alexander Huemer
On Mon, Aug 18, 2014 at 12:58:02PM +0200, Claudio wrote: > AFAIK a terminal is an hardware device. Yes. > Since st is only a software implementation it's ok to call it a > virtual terminal emulator, isn't? Is st emulating a virtual terminal? No. It is emulating a terminal. Kind regards, -Alex

Re: [dev] [PATCH] Simplify README

2014-08-18 Thread Roberto E. Vargas Caballero
> > Since st is only a software implementation it's ok to call it a > > virtual terminal emulator, isn't? > > Is st emulating a virtual terminal? No. It is emulating a terminal. The term 'emulator' itself already means that the terminal is a virtual, and not a real terminal. virtual terminal emu

Re: [dev] [PATCH] Simplify README

2014-08-18 Thread Weldon Goree
On Mon, 2014-08-18 at 12:58 +0200, Claudio wrote: > AFAIK a terminal is an hardware device. Since st is only a software > implementation it's ok to call it a virtual terminal emulator, isn't? > A virtual terminal presents the kernel the capabilities of a physical terminal (eg, /dev/tty3 or /dev/

[dev] [ubase][PATCH] Add lastlog.1

2014-08-18 Thread Roberto E. Vargas Caballero
--- Makefile | 2 ++ lastlog.1 | 12 ++ lastlog.c | 79 +++ 3 files changed, 93 insertions(+) create mode 100644 lastlog.1 create mode 100644 lastlog.c diff --git a/Makefile b/Makefile index 5a3f0fd..e54e6fa 100644 --- a/Make

[dev] [st] [PATCH] fix screen clearing in tresize

2014-08-18 Thread Quentin Carbonneaux
If defaultbg != 0, the alt screen is cleared with the wrong color. The bug is fixed by avoiding to load a cursor that might be 0 initialized. --- st.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/st.c b/st.c index 8f19018..783965e 100644 --- a/st.c +++ b/st.c @@

Re: [dev] [st] [PATCH] fix screen clearing in tresize

2014-08-18 Thread Roberto E. Vargas Caballero
> If defaultbg != 0, the alt screen is cleared with the wrong > color. The bug is fixed by avoiding to load a cursor that > might be 0 initialized. This patch also change the loop, and this change is not related to the bug you want to fix. Please send a patch for every issue. > - orig = ter

[dev] [st] [PATCH 1/3] remove empty trailing line

2014-08-18 Thread Quentin Carbonneaux
--- st.c | 1 - 1 file changed, 1 deletion(-) diff --git a/st.c b/st.c index 8f19018..835e6a1 100644 --- a/st.c +++ b/st.c @@ -3933,4 +3933,3 @@ run: return 0; } - -- 2.0.4

[dev] [PATCH 2/3] simplify loop in tresize

2014-08-18 Thread Quentin Carbonneaux
--- st.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/st.c b/st.c index 835e6a1..28e5b50 100644 --- a/st.c +++ b/st.c @@ -2661,7 +2661,6 @@ tresize(int col, int row) { int mincol = MIN(col, term.col); int slide = term.c.y - row + 1; bool *bp; -

[dev] [PATCH 3/3] reset the alt screen in treset

2014-08-18 Thread Quentin Carbonneaux
--- st.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/st.c b/st.c index 28e5b50..8488024 100644 --- a/st.c +++ b/st.c @@ -1356,9 +1356,12 @@ treset(void) { memset(term.trantbl, sizeof(term.trantbl), CS_USA); term.charset = 0; - tclearregion(0

Re: [dev] [ubase][PATCH] Add lastlog.1

2014-08-18 Thread Dimitris Papastamos
On Mon, Aug 18, 2014 at 03:26:30PM +0200, Roberto E. Vargas Caballero wrote: > --- > Makefile | 2 ++ > lastlog.1 | 12 ++ > lastlog.c | 79 > +++ > 3 files changed, 93 insertions(+) > create mode 100644 lastlog.1 > create mo

Re: [dev] [st] [PATCH 1/3] remove empty trailing line

2014-08-18 Thread Roberto E. Vargas Caballero
> > diff --git a/st.c b/st.c > index 8f19018..835e6a1 100644 > --- a/st.c > +++ b/st.c > @@ -3933,4 +3933,3 @@ run: > > return 0; > } I know git complaint about this line, but it is tradition in UNIX world to finish the files with an empty line, so calls to fgets will not be confused bec

Re: [dev] [st] [PATCH 1/3] remove empty trailing line

2014-08-18 Thread Quentin Carbonneaux
On Mon, Aug 18, 2014 at 08:32:51PM +0200, Roberto E. Vargas Caballero wrote: > I know git complaint about this line, but it is tradition in > UNIX world to finish the files with an empty line, so calls > to fgets will not be confused because there is not a newline > at the end of a line. There is

Re: [dev] [PATCH 3/3] reset the alt screen in treset

2014-08-18 Thread Roberto E. Vargas Caballero
Applied, thanks! -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH 1/3] remove empty trailing line

2014-08-18 Thread Roberto E. Vargas Caballero
> There is a newline at the end of file after applying this patch. > Currently, there are two newlines. Upsss, you are right. Applied. -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Simplify README

2014-08-18 Thread Claudio
I got it. Right. 2014-08-18 15:04 GMT+02:00 Weldon Goree : > On Mon, 2014-08-18 at 12:58 +0200, Claudio wrote: >> AFAIK a terminal is an hardware device. Since st is only a software >> implementation it's ok to call it a virtual terminal emulator, isn't? >> > > A virtual terminal presents the ker

[dev] [st][PATCH] Make useful DEL in application mode

2014-08-18 Thread Roberto E. Vargas Caballero
DEL key has to generate the sequence ^[P in application mode, because such sequence means delete current character. It implies that the character sent in keypad mode must be ^? (DEL character). --- config.def.h | 10 -- st.info | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-)

[dev] [st][PATCH] Fix definition of CONTROLC0

2014-08-18 Thread Roberto E. Vargas Caballero
DEL character is not thecnically talking a C0 control character, although it has some common properties with them, so it is useful for us consider it as C0. Before this patch DEL (\177), was not ignored as it ought to be. --- st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[dev] [st][PATCH] Improve execsh() and don't allow anonymous shells

2014-08-18 Thread Roberto E. Vargas Caballero
This patch improves the shell selection on execsh and forbid shell with users don't registered in the passwd file. --- st.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/st.c b/st.c index a207730..06761f1 100644 --- a/st.c +++ b/st.c @@ -1139,

Re: [dev] [st] [PATCH 1/3] remove empty trailing line

2014-08-18 Thread Christoph Lohmann
Greetings. On Tue, 19 Aug 2014 06:54:59 +0200 Quentin Carbonneaux wrote: > --- > st.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/st.c b/st.c > index 8f19018..835e6a1 100644 > --- a/st.c > +++ b/st.c > @@ -3933,4 +3933,3 @@ run: > > return 0; > } > - St style rule #308:

Re: [dev] [st] will global-less changes be wanted upstream?

2014-08-18 Thread Roberto E. Vargas Caballero
> I think this is a very nice summary of the situation. Are you maybe > aware of a webpage or some other text that describes this, maybe with > some code snippets, etc.? Well, I have searched some references in the net, but this is a really well known topic. You can read the description of rfork

Re: [dev] [st] [PATCH 1/3] remove empty trailing line

2014-08-18 Thread Roberto E. Vargas Caballero
> St style rule #308: Keep the last empty line. If you touch it you will > burn in some hell of your choice for the rest of your life. > > This is a religious moral code, so no justification needed. Ok, I didn't know it. I already said to you, I need a style guide ;) Regards, -- Roberto E.