[dev] Slock segfaults if USER variable is empty

2013-12-18 Thread Ivan Vershinin
Hello, people! I use slock for quite a strange purpose from time to time :). Namely, I run it using cron every 55 minutes, to get away from computer and stretch my body a little bit. But crontab file does not contain USER environment variable by default, so I'd spent a lot of time figuring out why

Re: [dev] Slock segfaults if USER variable is empty

2013-12-18 Thread Markus Teich
Ivan Vershinin wrote: > + user = getenv("USER"); > + if(!user) Heyho, I do not know how you guys think about this, but I would do that in one line: if(!(user = getenv("USER"))) --Markus

Re: [dev] Slock segfaults if USER variable is empty

2013-12-18 Thread Carlos Torres
Hello, On 12/18/13, Ivan Vershinin wrote: > But crontab file does not contain USER > environment variable by default, I might be missing something but doesn't crontab allow you to mention env variables in it, and it passes them to its execv? all you'd have to do is USER=ivan --Carlos

Re: [dev] Slock segfaults if USER variable is empty

2013-12-18 Thread Roberto E. Vargas Caballero
> I do not know how you guys think about this, but I would do that in one line: > > if(!(user = getenv("USER"))) I agree with you, although can be a discussion point if it is better or not something like: if ((user = getenv("USER)) != NULL) -- Roberto E. Vargas Caballero

Re: [dev] Slock segfaults if USER variable is empty

2013-12-18 Thread Alexander Huemer
On Wed, Dec 18, 2013 at 01:16:24PM -0500, Carlos Torres wrote: > > On 12/18/13, Ivan Vershinin wrote: > > But crontab file does not contain USER > > environment variable by default, > > I might be missing something but doesn't crontab allow > you to mention env variables in it, and it passes the

[dev] [sbase] printf(1)

2013-12-18 Thread Maurice Quennet
Hello dev@, I was searching for a programming project so I looked into TODO and picked printf. I hacked something up a few weeks ago, but I didn't publish it until now, since I didn't have a man page yet and I was a little busy (a patch follows at the end of the mail). In the following I will tel

Re: [dev] [sbase] printf(1)

2013-12-18 Thread William Giokas
On Wed, Dec 18, 2013 at 11:36:12PM +0100, Maurice Quennet wrote: > Hello dev@, > > I was searching for a programming project so I looked into TODO and > picked printf. I hacked something up a few weeks ago, but I didn't > publish it until now, since I didn't have a man page yet and I was a > litt

Re: [dev] [sbase] printf(1)

2013-12-18 Thread Chris Down
On 2013-12-18 21:06:08 -0600, William Giokas wrote: > People on this list need to learn about 'git format-patch' and 'git > send-email'... ...and about not quoting the entirety of the last message as context when it doesn't provide any. :-) pgpIqSRxp_FhA.pgp Description: PGP signature

Re: [dev] [sbase] printf(1)

2013-12-18 Thread Martti Kühne
On Wed, Dec 18, 2013 at 11:36 PM, Maurice Quennet wrote: > Hello dev@, > Hello mjq@, > diff --git a/Makefile b/Makefile > index 2a72a1c..e93f570 100644 [...] > +void > +printfmt(void) > +{ > + int e; > + long l; > + double d; > + char c, f, *tmp; > + > + if (*end ==