[dev] [st][PATCH] unsigned function tdefcolor returns -1 on error

Hi I found that tdefcolor returns -1 on error, while its return type is unsigned long. At the same time, line 1724 and 1731 are checking the positivity of its unsigned return value. Since the actual color values are 24 bits long, it should be okay to cast the return value to long before checking

Re: [dev] [sbase] [patch] Add sha512sum(1)

>> David, let me know if this is ok. > I KNEW there was something I forgot to apply! I'll try > to do this tonight. Applied! > At this point we could have a helper function in util/ > to parse the checksums in files so we can easily support > the -c flag in md5sum, sha1sum and sha{256,512}sum. I a

Re: [dev] [sbase] [patch] Add sha512sum(1)

On Sun, Aug 04, 2013 at 11:08:35AM -0400, Galos, David wrote: > >> David, let me know if this is ok. > > I KNEW there was something I forgot to apply! I'll try > > to do this tonight. > Applied! > > > At this point we could have a helper function in util/ > > to parse the checksums in files so we

Re: [dev] [st][PATCH] unsigned function tdefcolor returns -1 on error

On Sun, Aug 04, 2013 at 08:54:35AM -0400, Eon S. Jeon wrote: > Hi > > I found that tdefcolor returns -1 on error, while its return type is > unsigned long. At the same time, line 1724 and 1731 are checking the > positivity of its unsigned return value. > > @@ -1721,14 +1721,14 @@ tsetattr(int *at