Re: [dev] [sbase] [patch] Adding tar v2

2013-07-14 Thread Nick
Quoth Galos, David: > Thanks in large part to your information about how you invoke tar, I > believe I have come up with a decent solution. I also was able to > find the structified version of tar I had worked on in the past. I'd be inclined to check for and filter out leading .. and / characters

Re: [dev] [dwm] [patch] Fix warning about XKeycodeToKeysym

2013-07-14 Thread Anselm R Garbe
Hi Alexander, On 12 July 2013 14:03, Alexander Rødseth wrote: > Attaching a patch for fixing a warning about XKeycodeToKeysym, by > replacing it with a call to XGetKeyboardMapping. Which warning are you referring to? Also in your suggested patch keysyms_per_keycode_return is never evaluated, tho

Re: [dev] dwm bit fields conversion

2013-07-14 Thread Anselm R Garbe
On 7 July 2013 16:49, koneu wrote: > In Xdefs.h, Bool is typedef'd as int (= at least 2 bytes, sometimes more, > depending on the implementation), of which we set the last bit to 1 or 0. > In the Monitor and Client structures dwm uses, we can instead use char bit > fields, storing up to 8 Bool v

Re: [dev] [sbase] [patch] Adding tar v2

2013-07-14 Thread Chris Down
On 14 July 2013 20:42, Nick wrote: > Quoth Galos, David: >> Thanks in large part to your information about how you invoke tar, I >> believe I have come up with a decent solution. I also was able to >> find the structified version of tar I had worked on in the past. > > I'd be inclined to check for

Re: [dev] dwm bit fields conversion

2013-07-14 Thread Markus Teich
Since this is just uncommon syntax (at least I haven't seen it before) and it is just used in the declaration I would be ok with it, if an additional comment explains it. It's not a strong opinion though, just an idea. --Markus Am 2013-07-14 21:32, schrieb Anselm R Garbe: On 7 July 2013 16:

[dev] [sbase] Patch to make md5 and sha1 more similar

2013-07-14 Thread Jens Nyberg
Hi, I've included a patch that makes minor changes to md5 and sha1. Both hashing functions are pretty similar but the code differed in a few places so I cleaned them both up a bit. Also I made some minor changes like moving the rol function to below the definitions and also instead of *= 8 I did

Re: [dev] dwm bit fields conversion

2013-07-14 Thread pancake
I should check generated code, but usually a mov is faster than mov+and+mov for setting a bit. On Jul 14, 2013, at 23:22, Markus Teich wrote: > Since this is just uncommon syntax (at least I haven't seen it before) and it > is just used in the declaration I would be ok with it, if an additiona