Re: [dev] [surf] [PATCH] Clean up SSL validation

2014-01-30 Thread YpN
Christoph Lohmann <2...@r-36.net> wrote: > Both of your patches have been applied. Thank you for sending them! I'm glad to see all those patches applied upstream. It was an exciting week for surf. Regards Y.

Re: [dev] [surf] [PATCH] Clean up SSL validation

2014-01-30 Thread Christoph Lohmann
Greetings. On Thu, 30 Jan 2014 19:40:21 +0100 Steve Dee wrote: > soup_message_get_flags returns a bunch of flags besides > SOUP_MESSAGE_CERTIFICATE_TRUSTED, so the XOR check was incorrect. > > While I was tracking this bug, I switched from libsoup's deprecated [0] > ssl-ca-file to its non-deprec

Re: [dev] [surf] [PATCH] Clean up SSL validation

2014-01-27 Thread Nick
Quoth Steve Dee: > soup_message_get_flags returns a bunch of flags besides > SOUP_MESSAGE_CERTIFICATE_TRUSTED, so the XOR check was incorrect. Ah great, thanks for that patch, works perfectly. I meant to look into this, but didn't find the time, so thanks.