Re: [dev] [st] possibly redundant check in techo

2014-08-15 Thread Martti Kühne
Do we sound like we want an additional clause in the license? Addendum: In case source files are split from this license document in a different directory structure, help us find the license by noting the path with huge ASCII-art characters in every affected source file. cheers! mar77i

Re: [dev] [st] possibly redundant check in techo

2014-08-15 Thread Eric Pruitt
On Fri, Aug 15, 2014 at 12:35:06PM -0300, Amadeus Folego wrote: > Steven, when you first disclose your project publicly, please adjust the > proper License requirements. > > From what I see, it looks like you stripped everything of the codebase > and previous structure. I don't understand what the

Re: [dev] [st] possibly redundant check in techo

2014-08-15 Thread Martti Kühne
No. Github isn't a workbench that is public by accident. By uploading to Github you release your project to the public. Start treating it that way and start treating projects you incorporate into your code in a way that makes you look like a responsible human being. cheers! mar77i

Re: [dev] [st] possibly redundant check in techo

2014-08-15 Thread Steven Degutis
Amadeus, I will certainly move all the license files back when it is publicly released. All I've done right now is moved all the files out of the root directory into a subdirectory, so that people don't mistakenly think the port is ready for any kind of use. -Steven On Fri, Aug 15, 2014 at 10:35

Re: [dev] [st] possibly redundant check in techo

2014-08-15 Thread Amadeus Folego
Steven, when you first disclose your project publicly, please adjust the proper License requirements. >From what I see, it looks like you stripped everything of the codebase and previous structure.

Re: [dev] [st] possibly redundant check in techo

2014-08-15 Thread Steven Degutis
> It is already pushed. You can test it. I don't have linux installed. However, I have applied the patch on my OS X port, and although development is in a very early phase, it seems to function as normal (briefly using vim and emacs and bash within my terminal). Thanks. -Steven

Re: [dev] [st] possibly redundant check in techo

2014-08-15 Thread Roberto E. Vargas Caballero
> > Maybe we should change the line to: > > > > if(ISCONTROL((uchar) c)) { /* control code */ > > Yes, that sounds like a reasonable solution. It is already pushed. You can test it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] possibly redundant check in techo

2014-08-14 Thread Steven Degutis
> What processador do you use in your port? intel or ibm? I'm on OS X 10.9 on an Intel Mac Pro, using LLVM + Clang. > There was a discussion in this list sometime ago about this > topic, and I think this was the best solution (if someone can > find the messages ...), but I agree that if char is s

Re: [dev] [st] possibly redundant check in techo

2014-08-14 Thread Roberto E. Vargas Caballero
On Thu, Aug 14, 2014 at 04:38:24PM -0500, Steven Degutis wrote: > Convenience link to the line: http://git.suckless.org/st/tree/st.c#n2315 > > Here, techo is calling ISCONTROL(c) where c is a 'char'. But > ISCONTROLC1 is always going to return false for a char. This is not true, char can be signe