Re: [dev] [sbase] [patch v3] Who(1) patches

2013-08-07 Thread sin
On Wed, Aug 07, 2013 at 02:58:02AM -0400, Galos, David wrote: > I have written the manpage, and pushed this. I have also cleaned > up who, and addedthe '-l' flag. > > > Good stuff! > Except for the way that strings were handled when adding '-m' > Both ttyname and strrchr could have easily returned

Re: [dev] [sbase] [patch v3] Who(1) patches

2013-08-06 Thread Galos, David
I have written the manpage, and pushed this. I have also cleaned up who, and addedthe '-l' flag. > Good stuff! Except for the way that strings were handled when adding '-m' Both ttyname and strrchr could have easily returned NULL, so that should have been checked for. I've fixed this in the cleanu

Re: [dev] [sbase] [patch v3] Who(1) patches

2013-08-06 Thread Galos, David
> v3 of the who(1) patchset. Good stuff! I'd rather not push until the manpage is updated with the m option, though